[build] Ensure group kibana is added, stricter user creation by jbudz · Pull Request #7510 · elastic/kibana

jbudz · 2016-06-20T18:11:31Z

This explicitly adds the kibana group instead of relying on useradd -r to create a corresponding group.
Closes #7475

LeeDr · 2016-07-05T23:13:34Z

@jbudz: I just tried building the packages and got this error;

Invalid package configuration: Cannot package the path '/home/leedr/git/kibana/build/services/systemd/lib', does it exist? {:level=>:error}

The directory indeed does not exist. I could just create it manually and run again for now...

jbudz · 2016-07-05T23:50:06Z

@LeeDr master still expects pleaserun 0.0.16 until #7276 is merged

jbudz · 2016-07-07T18:05:24Z

jenkins, test this

jbudz · 2016-07-07T19:29:32Z

Rebased, 0.0.24 now.

LeeDr · 2016-07-07T20:08:54Z

Build worked fine now. Now it's just down to the testing...

LeeDr · 2016-07-07T20:41:19Z

I tried install, then remove, then purge but got an error when it tried to delete the group;
(NOTE That this happened before jbudz push above and should be fixed now)

root@ubuntu64:~/git/kibana/target# dpkg -r kibana
(Reading database ... 233975 files and directories currently installed.)
Removing kibana (5.0.0-alpha5-SNAPSHOT) ...
Stopping kibana service... OK
root@ubuntu64:~/git/kibana/target# 
root@ubuntu64:~/git/kibana/target# grep kibana /etc/group
kibana:x:129:
root@ubuntu64:~/git/kibana/target# grep kibana /etc/passwd
kibana:x:121:129::/home/kibana:/bin/false
root@ubuntu64:~/git/kibana/target# 
root@ubuntu64:~/git/kibana/target# dpkg -P kibana
(Reading database ... 214837 files and directories currently installed.)
Removing kibana (5.0.0-alpha5-SNAPSHOT) ...
Purging configuration files for kibana (5.0.0-alpha5-SNAPSHOT) ...
groupdel: cannot remove the primary group of user 'kibana'  <<<<<<<<<<<<<<<<<<<
dpkg: error processing package kibana (--purge):
 subprocess installed post-removal script returned error exit status 8
Errors were encountered while processing:
 kibana
root@ubuntu64:~/git/kibana/target# 
root@ubuntu64:~/git/kibana/target# grep kibana /etc/group
kibana:x:129:
root@ubuntu64:~/git/kibana/target# grep kibana /etc/passwd
kibana:x:121:129::/home/kibana:/bin/false

LeeDr · 2016-07-07T20:50:43Z

The last commit fixed the user/group delete issue.

root@ubuntu64:~/git/kibana/target# dpkg -i kibana-5.0.0-alpha5-SNAPSHOT-amd64.deb
Selecting previously unselected package kibana.
(Reading database ... 214834 files and directories currently installed.)
Preparing to unpack kibana-5.0.0-alpha5-SNAPSHOT-amd64.deb ...
Unpacking kibana (5.0.0-alpha5-SNAPSHOT) ...
Setting up kibana (5.0.0-alpha5-SNAPSHOT) ...
Processing triggers for systemd (229-4ubuntu6) ...
Processing triggers for ureadahead (0.100.0-19) ...
root@ubuntu64:~/git/kibana/target# 
root@ubuntu64:~/git/kibana/target# 
root@ubuntu64:~/git/kibana/target# grep kibana /etc/passwd
kibana:x:121:129::/home/kibana:/bin/false
root@ubuntu64:~/git/kibana/target# grep kibana /etc/group
kibana:x:129:
root@ubuntu64:~/git/kibana/target# dpkg -r kibana
(Reading database ... 233975 files and directories currently installed.)
Removing kibana (5.0.0-alpha5-SNAPSHOT) ...
Stopping kibana service... OK
root@ubuntu64:~/git/kibana/target# grep kibana /etc/passwd
kibana:x:121:129::/home/kibana:/bin/false
root@ubuntu64:~/git/kibana/target# grep kibana /etc/group
kibana:x:129:
root@ubuntu64:~/git/kibana/target# dpkg -P kibana
(Reading database ... 214836 files and directories currently installed.)
Removing kibana (5.0.0-alpha5-SNAPSHOT) ...
Purging configuration files for kibana (5.0.0-alpha5-SNAPSHOT) ...
root@ubuntu64:~/git/kibana/target# grep kibana /etc/passwd
root@ubuntu64:~/git/kibana/target# grep kibana /etc/group
root@ubuntu64:~/git/kibana/target#

NOTE that I did NOT start Kibana in the test above.

LeeDr · 2016-07-07T22:20:31Z

LGTM
I checked and both my Ubuntu 16 and CentOS7 have
USERGROUPS_ENAB yes in /etc/login.defs

On CentOS I installed and removed with it set to yes and no (rebooted after changing). The kibana user and group were created by the install and removed by the dpkg -P on Ubuntu and yum remove on CentOS.

--------- **Commit 1:** [build] Ensure group kibana is added, stricter user creation * Original sha: b54ef4e * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-06-20T15:27:36Z **Commit 2:** [build] Remove user before group * Original sha: 144a40b * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-07-07T20:40:18Z

[backport] PR #7510 to 4.x

[build] Ensure group kibana is added, stricter user creation Former-commit-id: 13ec202

`v93.0.0` ⏩ `v93.1.1` --- ## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0) **This is a patch release primarily intended for use by Kibana.** - Added top-level `EuiTreeView.Item` export ([#7526](elastic/eui#7526)) ## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0) - Added `index` glyph to `EuiIcon` ([#7498](elastic/eui#7498)) - Updated `EuiHighlight` to accept an array of `search` strings, which allows highlighting multiple, separate words within its children. This new type and behavior *only* works if `highlightAll` is also set to true. ([#7496](elastic/eui#7496)) - Updated `EuiContextMenu` with a new `panels.items.renderItem` property, which allows rendering completely custom items next to standard `EuiContextMenuItem` objects ([#7510](elastic/eui#7510)) - `EuiSuperDatePicker` updates: - Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([#7501](elastic/eui#7501)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `intervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([#7501](elastic/eui#7501)) - Updated `onRefreshChange` to pass back a new `intervalUnits` key that contains the current interval unit format (seconds, minutes, or hours). ([#7501](elastic/eui#7501)) - Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop, which defaults to true (current behavior). To preserve displaying the unit that users select for relative time, set this to false. ([#7502](elastic/eui#7502)) - Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop, which accepts a minimum number in milliseconds ([#7516](elastic/eui#7516)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `minInterval` prop, which accepts a minimum number in milliseconds ([#7516](elastic/eui#7516)) **Bug fixes** - Fixed `EuiHighlight` to not parse `search` strings as regexes ([#7496](elastic/eui#7496)) - Fixed `EuiSuperDatePicker` submit bug when used within `<form>` elements ([#7504](elastic/eui#7504)) - Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to items without expandable children ([#7513](elastic/eui#7513)) **CSS-in-JS conversions** - Converted `EuiTreeView` to Emotion. Updates as part of the conversion: ([#7513](elastic/eui#7513)) - Removed `.euiTreeView__wrapper` div node - Enforced consistent `icon` size based on `display` size

`v93.0.0` ⏩ `v93.1.1` --- ## [`v93.1.1`](https://github.com/elastic/eui/releases/v93.2.0) **This is a patch release primarily intended for use by Kibana.** - Added top-level `EuiTreeView.Item` export ([elastic#7526](elastic/eui#7526)) ## [`v93.1.0`](https://github.com/elastic/eui/releases/v93.1.0) - Added `index` glyph to `EuiIcon` ([elastic#7498](elastic/eui#7498)) - Updated `EuiHighlight` to accept an array of `search` strings, which allows highlighting multiple, separate words within its children. This new type and behavior *only* works if `highlightAll` is also set to true. ([elastic#7496](elastic/eui#7496)) - Updated `EuiContextMenu` with a new `panels.items.renderItem` property, which allows rendering completely custom items next to standard `EuiContextMenuItem` objects ([elastic#7510](elastic/eui#7510)) - `EuiSuperDatePicker` updates: - Updated `EuiSuperDatePicker` with a new `refreshIntervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([elastic#7501](elastic/eui#7501)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `intervalUnits` prop. Passing this prop allows controlling and overriding the default unit rounding behavior. ([elastic#7501](elastic/eui#7501)) - Updated `onRefreshChange` to pass back a new `intervalUnits` key that contains the current interval unit format (seconds, minutes, or hours). ([elastic#7501](elastic/eui#7501)) - Updated `EuiSuperDatePicker` with a new `canRoundRelativeUnits` prop, which defaults to true (current behavior). To preserve displaying the unit that users select for relative time, set this to false. ([elastic#7502](elastic/eui#7502)) - Updated `EuiSuperDatePicker` with a new `refreshMinInterval` prop, which accepts a minimum number in milliseconds ([elastic#7516](elastic/eui#7516)) - Updated `EuiAutoRefresh` and `EuiRefreshInterval` with a new `minInterval` prop, which accepts a minimum number in milliseconds ([elastic#7516](elastic/eui#7516)) **Bug fixes** - Fixed `EuiHighlight` to not parse `search` strings as regexes ([elastic#7496](elastic/eui#7496)) - Fixed `EuiSuperDatePicker` submit bug when used within `<form>` elements ([elastic#7504](elastic/eui#7504)) - Fixed an `EuiTreeView` bug where `aria-expanded` was being applied to items without expandable children ([elastic#7513](elastic/eui#7513)) **CSS-in-JS conversions** - Converted `EuiTreeView` to Emotion. Updates as part of the conversion: ([elastic#7513](elastic/eui#7513)) - Removed `.euiTreeView__wrapper` div node - Enforced consistent `icon` size based on `display` size

jbudz added review v5.0.0-beta1 labels Jun 20, 2016

jbudz assigned LeeDr Jun 20, 2016

jbudz force-pushed the issues/7475 branch from 1fc0947 to 71db326 Compare July 5, 2016 23:48

[build] Ensure group kibana is added, stricter user creation

b54ef4e

jbudz force-pushed the issues/7475 branch from 71db326 to b54ef4e Compare July 7, 2016 19:29

[build] Remove user before group

144a40b

LeeDr assigned jbudz and unassigned LeeDr Jul 7, 2016

jbudz merged commit 13ec202 into elastic:master Jul 8, 2016

elastic-jasper mentioned this pull request Jul 8, 2016

[backport] PR #7510 to 4.x #7683

Merged

jbudz added a commit that referenced this pull request Jul 8, 2016

Merge pull request #7683 from elastic/jasper/backport/7510/4.x

f92bc14

[backport] PR #7510 to 4.x

epixa added v5.0.0-alpha5 and removed v5.0.0-beta1 labels Jul 20, 2016

epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7510 from jbudz/issues/7475

11f5067

[build] Ensure group kibana is added, stricter user creation Former-commit-id: 13ec202

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[build] Ensure group kibana is added, stricter user creation#7510

[build] Ensure group kibana is added, stricter user creation#7510
jbudz merged 2 commits intoelastic:masterfrom
jbudz:issues/7475

jbudz commented Jun 20, 2016

Uh oh!

LeeDr commented Jul 5, 2016

Uh oh!

jbudz commented Jul 5, 2016

Uh oh!

jbudz commented Jul 7, 2016

Uh oh!

jbudz commented Jul 7, 2016

Uh oh!

LeeDr commented Jul 7, 2016

Uh oh!

LeeDr commented Jul 7, 2016 •

edited

Loading

Uh oh!

LeeDr commented Jul 7, 2016 •

edited

Loading

Uh oh!

LeeDr commented Jul 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jbudz commented Jun 20, 2016

Uh oh!

LeeDr commented Jul 5, 2016

Uh oh!

jbudz commented Jul 5, 2016

Uh oh!

jbudz commented Jul 7, 2016

Uh oh!

jbudz commented Jul 7, 2016

Uh oh!

LeeDr commented Jul 7, 2016

Uh oh!

LeeDr commented Jul 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeeDr commented Jul 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeeDr commented Jul 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LeeDr commented Jul 7, 2016 •

edited

Loading

LeeDr commented Jul 7, 2016 •

edited

Loading