[Ingest Manager] Rename agent/package config(s) to agent/package policy(ies)#74914
Merged
jen-huang merged 30 commits intoelastic:masterfrom Aug 19, 2020
Merged
[Ingest Manager] Rename agent/package config(s) to agent/package policy(ies)#74914jen-huang merged 30 commits intoelastic:masterfrom
jen-huang merged 30 commits intoelastic:masterfrom
Conversation
…nt by agent, though)
10 tasks
… ever sent by agent, though)" This reverts commit 3c91e01.
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
paul-tavares
approved these changes
Aug 19, 2020
Contributor
paul-tavares
left a comment
There was a problem hiding this comment.
WOW 😲
Thanks @jen-huang for the changes under Security Solution. I checked out this locally and did a light drive and looks good.
@madirey , @nnamdifrankie - just FYI. if you have a chance, just give it a glance to the Manifest manager changes as well as server other server modules.
jfsiii
approved these changes
Aug 19, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
👀 👏
I checked this out locally and did some light creating/editing of package & agent policies. I also did some requests on the /api/*/*_policies routes and everything worked as expected
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Aug 19, 2020
…cy(ies) (elastic#74914) * Initial pass at updating client routes, variables names, code comments, and UI copy * Adjust server routes and param names, more var names and i18n fixes * Fix test * More var renaming * Rest of server-side var renaming * Rest of client side var renaming * Rename agent SO attributes and add migrations * Remove agent prefix from policy fields * Rename agent policy SO attributes and add migrations * Rename enrollment api key SO attributes and add migrations * Rename package policy SO attributes and add migrations * Rename agent event SO attributes and add migrations * Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though) * Update snapshot * Remove unnecessary cloning in migrations * Fix migration typos * Update naming in tests and es archiver data * Rename file names in /common * Rename /server files * Rename /public files * Rename test file names * Rename missed files * Revert "Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though)" This reverts commit 3c91e01. * Add migration version to updated es archiver data to fix tests
1 task
jen-huang
added a commit
that referenced
this pull request
Aug 19, 2020
…cy(ies) (#74914) (#75495) * Initial pass at updating client routes, variables names, code comments, and UI copy * Adjust server routes and param names, more var names and i18n fixes * Fix test * More var renaming * Rest of server-side var renaming * Rest of client side var renaming * Rename agent SO attributes and add migrations * Remove agent prefix from policy fields * Rename agent policy SO attributes and add migrations * Rename enrollment api key SO attributes and add migrations * Rename package policy SO attributes and add migrations * Rename agent event SO attributes and add migrations * Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though) * Update snapshot * Remove unnecessary cloning in migrations * Fix migration typos * Update naming in tests and es archiver data * Rename file names in /common * Rename /server files * Rename /public files * Rename test file names * Rename missed files * Revert "Rename subtype CONFIG to POLICY (I don't think this string is ever sent by agent, though)" This reverts commit 3c91e01. * Add migration version to updated es archiver data to fix tests
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #74842. This PR renames agent/package config(s) to agent/package policy(ies) everywhere in Ingest Manager plugin code:
Partial changes were also made in Endpoint (
security_solutionplugin) code where references to Ingest Manager routes, types, and methods exist, as well as patching test suites as needed. But I did not audit or change Endpoint file names or UI copy. I am hoping someone from the Endpoint team can pick any remaining changes.Testing
Everything should just work as prior to this PR, with no UI changes except for copy.
To support renaming of Ingest Manager SO attributes, SO migrations were added to ensure that the user does not encounter any mapping errors going from 7.9 to the next release. Please test this PR with Ingest Manager data (various integrations installed, multiple configs, agents enrolled, etc) prior to this PR , stop Kibana, pull down this PR, and restart Kibana. The SO migrations should kick in and your data should be displayed in Ingest Manager the same as before.
Note: you'll probably want to wipe your data if you switch out of this PR as the migrations don't kick in the other way around!
Dev Docs
The following Ingest Manager API routes were changed:
/api/ingest_manager/agent_configs/*renamed to/api/fleet/agent_policies/*/api/ingest_manager/package_configs/*renamed to/api/fleet/package_policies/*All Ingest Manager routes with payload fields that were previously in reference to agent configs or package configs, have been renamed to agent policies and package policies. For example
configId->policyId,package_configs->package_policies.The following Ingest Manager app routes were changed:
/app/ingestManager#/configsrenamed to/app/ingestManager#/policiesThe following Ingest Manager settings were changed:
xpack.ingestManager.fleet.agentConfigRolloutRateLimitIntervalMsrenamed toxpack.fleet.agents.agentPolicyRolloutRateLimitIntervalMsxpack.fleet.agents.agentConfigRolloutRateLimitRequestPerIntervalrenamed toxpack.fleet.agents.agentPolicyRolloutRateLimitRequestPerInterval