Build task for os packages creates target#7485
Merged
epixa merged 2 commits intoelastic:masterfrom Jun 16, 2016
Merged
Conversation
The target directory is created by the archives task, but it is not created by the ospackages task, so if you do not have a target directory and try to skip archives, the build will fail.
Contributor
|
LGTM |
Contributor
|
I just merged #7484 where this was introduced, this'll need to go to 4.x now too |
Contributor
Author
|
Whoops. This should really be using the target directory configuration rather than a hardcoded string. Archives should a well. I'll update this PR. |
The target directory was being created based on a hardcoded string rather from the target directory configuration value.
Contributor
Author
|
Fixed |
Contributor
|
👍 |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Build task for os packages creates target Former-commit-id: c46172d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target directory is created by the archives task, but it is not
created by the ospackages task, so if you do not have a target
directory and try to skip archives, the build will fail.