Skip to content

[build] Cleanup dirs on uninstall#7422

Merged
jbudz merged 1 commit intoelastic:masterfrom
jbudz:package-dirs
Jun 15, 2016
Merged

[build] Cleanup dirs on uninstall#7422
jbudz merged 1 commit intoelastic:masterfrom
jbudz:package-dirs

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Jun 10, 2016

On package purge or removal, this cleans up the installed/generated files in the optimize and plugins dirs

@LeeDr
Copy link
Copy Markdown

LeeDr commented Jun 10, 2016

LGTM

I did a local build of ospackages on Ubuntu and installed the 64-bit deb package with
dpkg -i target/kibana_5.0.0-snapshot_amd64.deb

I started and stopped Kibana service, and tried to install some plugins but nothing was compatible with this snapshot.

I uninstalled with dpkg --purge kibana and both /usr/share/kibana and /etc/kibana were both removed.

I reinstalled, started/stopped the service, and then uninstalled with dpkg --remove kibana
This left the empty /usr/share/kibana/ directory, and /etc/kibana/kibana.yml

@LeeDr
Copy link
Copy Markdown

LeeDr commented Jun 10, 2016

jenkins, test it

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Jun 15, 2016

Any reason not to backport this to 4.6?

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Jun 15, 2016

LGTM

@epixa epixa assigned jbudz and epixa and unassigned w33ble Jun 15, 2016
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Jun 15, 2016

Nope, this would be good to backport.

@jbudz jbudz added the v4.6.0 label Jun 15, 2016
@jbudz jbudz merged commit 314e095 into elastic:master Jun 15, 2016
elastic-jasper added a commit that referenced this pull request Jun 16, 2016
---------

**Commit 1:**
[build] Cleanup dirs on uninstall

* Original sha: 29e26de
* Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-25T22:05:28Z
jbudz added a commit that referenced this pull request Jun 17, 2016
---------

**Commit 1:**
[build] Cleanup dirs on uninstall

* Original sha: 29e26de
* Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-25T22:05:28Z
jbudz added a commit that referenced this pull request Jun 17, 2016
@epixa epixa added v5.0.0 and removed v5.0.0 labels Jun 28, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[build] Cleanup dirs on uninstall

Former-commit-id: 314e095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants