[Monitoring] Handle cloud test failures#74162
Merged
chrisronline merged 4 commits intoelastic:masterfrom Aug 31, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
igoristic
reviewed
Aug 31, 2020
| //it moves on to the cluster overview page. | ||
| await retry.try(async () => { | ||
| // it moves on to the cluster overview page. | ||
| await retry.tryForTime(10000, async () => { |
Contributor
There was a problem hiding this comment.
nit: Ten seconds seems kind of long. Is there any way to add Promise.race() condition? Maybe OR if a certain element is visible?
But, I think it's still fine if not, so up to you
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Aug 31, 2020
Contributor
Author
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 3, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/test/functional/apps/monitoring/time_filter.js
chrisronline
added a commit
that referenced
this pull request
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63055
Fixes #72191
Best way to test this is to stand up a cloud cluster and run the functional test runner against it, something like: