[Vega] add functional tests for Vega visualization by alexwizp · Pull Request #74097 · elastic/kibana

alexwizp · 2020-08-03T15:23:16Z

Part of #21721

Summary

Add function tests for:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2020-08-05T09:33:42Z

@elasticmachine merge upstream

test/functional/services/remote/webdriver.ts

# Conflicts: # test/functional/apps/visualize/_vega_chart.ts

alexwizp · 2020-08-10T09:36:13Z

@elasticmachine merge upstream

elasticmachine · 2020-08-10T09:38:04Z

Pinging @elastic/kibana-app (Team:KibanaApp)

test/functional/services/index.ts

test/functional/apps/visualize/_vega_chart.ts

test/functional/services/common/browser.ts

test/functional/services/data_grid.ts

dmlemeshko · 2020-08-10T14:05:54Z

I got 2/30 failures with https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/767/

Kibana Pipeline / agent-2 / Chrome UI Functional Tests.test/functional/apps/visualize/_vega_chart·ts.visualize app vega chart in visualize app Vega extension functions should remove all filters by calling "kibanaRemoveAllFilters" expression (from (TEST-job-kibana-ciGroup12-worker-1-Chrome UI Functional Tests.xml))
{ TimeoutError: Waiting for element to be located By(css selector, div.vgaVis__view)
Wait timed out after 10033ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

@alexwizp please check how it can be improved

alexwizp · 2020-08-11T14:33:44Z

@elasticmachine merge upstream

dmlemeshko

Code LGTM.
Flaky test runner 40/40 https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/773/

stratoula

LGTM, very happy for this PR 🎉

* [Vega] [Inspector] add functional tests for Request tab * add some tests for Vega Debug tab * add clipboard permissions for webdriver * add smoke tests for data grid * fix CI * add some tests for vega expression funcitons * change order * Update _vega_chart.ts * Rename dagta_grid.ts to data_grid.ts * Update index.ts * Update data_grid.ts * stabilize tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [Vega] add functional tests for Vega visualization (elastic#74097) [ML] Removing full lodash library imports (elastic#74742) [Search] Server strategy example (elastic#71679) [Reporting] Fix and test for Listing of Reports (elastic#74453) [maps] fix drawing shapes (elastic#74689) [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601) Deprecate schema-less specs in Vega (elastic#73805) [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287) Timelion deprecation doc (elastic#74508)

* [Vega] [Inspector] add functional tests for Request tab * add some tests for Vega Debug tab * add clipboard permissions for webdriver * add smoke tests for data grid * fix CI * add some tests for vega expression funcitons * change order * Update _vega_chart.ts * Rename dagta_grid.ts to data_grid.ts * Update index.ts * Update data_grid.ts * stabilize tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine · 2020-11-10T12:14:08Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8a9c069
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for f621b0e were not reported

History

💚 Build #67567 succeeded 8a9c069
💚 Build #67520 succeeded 1a4d265
💚 Build #67244 succeeded f11ce94
💚 Build #67212 succeeded cf8ec00

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[Vega] [Inspector] add functional tests for Request tab

b573f0e

elasticmachine and others added 3 commits August 5, 2020 03:33

Merge branch 'master' into vega_tests

64ff1ef

add some tests for Vega Debug tab

258351b

add clipboard permissions for webdriver

ec7e97e

dmlemeshko reviewed Aug 6, 2020

View reviewed changes

test/functional/services/remote/webdriver.ts Outdated Show resolved Hide resolved

alexwizp added 6 commits August 6, 2020 17:48

add smoke tests for data grid

c85de6d

fix CI

92c90cf

add some tests for vega expression funcitons

4e1fe19

Merge remote-tracking branch 'upstream/master' into vega_tests

4065901

# Conflicts: # test/functional/apps/visualize/_vega_chart.ts

change order

0d84a64

Update _vega_chart.ts

60fa7af

alexwizp marked this pull request as ready for review August 10, 2020 09:35

alexwizp requested a review from a team August 10, 2020 09:35

alexwizp requested a review from a team as a code owner August 10, 2020 09:35

Merge branch 'master' into vega_tests

0cfd5fa

alexwizp self-assigned this Aug 10, 2020

alexwizp added Feature:Vega Vega visualizations v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Aug 10, 2020

alexwizp added the automation label Aug 10, 2020

stratoula reviewed Aug 10, 2020

View reviewed changes

test/functional/services/index.ts Outdated Show resolved Hide resolved

alexwizp added 2 commits August 10, 2020 14:23

Rename dagta_grid.ts to data_grid.ts

96b2efe

Update index.ts

cf8ec00

dmlemeshko reviewed Aug 10, 2020

View reviewed changes

test/functional/apps/visualize/_vega_chart.ts Show resolved Hide resolved

test/functional/services/common/browser.ts Show resolved Hide resolved

test/functional/services/data_grid.ts Show resolved Hide resolved

Update data_grid.ts

f11ce94

elasticmachine and others added 2 commits August 11, 2020 08:33

Merge branch 'master' into vega_tests

1a4d265

stabilize tests

8a9c069

dmlemeshko self-requested a review August 12, 2020 10:42

dmlemeshko approved these changes Aug 12, 2020

View reviewed changes

stratoula approved these changes Aug 12, 2020

View reviewed changes

alexwizp merged commit 21b9b36 into elastic:master Aug 12, 2020

alexwizp mentioned this pull request Aug 12, 2020

[7.x] [Vega] add functional tests for Vega visualization (#74097) #74843

Merged

timroes mentioned this pull request Aug 12, 2020

Bringing Vega out of experimental #21721

Closed

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vega] add functional tests for Vega visualization#74097

[Vega] add functional tests for Vega visualization#74097
alexwizp merged 16 commits intoelastic:masterfrom
alexwizp:vega_tests

alexwizp commented Aug 3, 2020 •

edited by zube bot

Loading

Uh oh!

alexwizp commented Aug 5, 2020

Uh oh!

Uh oh!

alexwizp commented Aug 10, 2020

Uh oh!

elasticmachine commented Aug 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmlemeshko commented Aug 10, 2020

Uh oh!

alexwizp commented Aug 11, 2020

Uh oh!

dmlemeshko left a comment

Uh oh!

stratoula left a comment

Uh oh!

kibanamachine commented Nov 10, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

alexwizp commented Aug 3, 2020 • edited by zube bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

alexwizp commented Aug 5, 2020

Uh oh!

Uh oh!

alexwizp commented Aug 10, 2020

Uh oh!

elasticmachine commented Aug 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dmlemeshko commented Aug 10, 2020

Uh oh!

alexwizp commented Aug 11, 2020

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Nov 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexwizp commented Aug 3, 2020 •

edited by zube bot

Loading

kibanamachine commented Nov 10, 2020 •

edited

Loading