Merged
Conversation
1 task
Contributor
Author
|
@elastic/kibana-telemetry I need your help to fix a failed telemetry test |
Member
|
@restrry ACK! I'll take a look at it tomorrow morning if that's OK. |
mshustov
commented
Aug 6, 2020
| delete esAgg.agg; | ||
| delete esAgg.aggName; | ||
| delete esAgg.dropDownName; | ||
| const { agg, aggName, dropDownName, ...esAgg } = groupByConfig; |
Contributor
Author
There was a problem hiding this comment.
omit via restructuring instead of property deletion
Contributor
Author
|
@afharo Telemetry tests are failing again. Would you mind taking a look, please? |
kindsun
approved these changes
Aug 26, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Maps changes lgtm!
- code review
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
oss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Aug 27, 2020
* bump ts to v4 * MOAR RAM * fix type errors for OSS * first pass on x-pack errors * second pass on x-pack type errors * 3rd pass on x-pack type-errors * mute errors if complex cases * don't delete if spread suffices * mute other complex cases * make User fields optional * fix optional types * fix tests * fix typings for time_range * fix type errors in x-pack/tests * rebuild kbn-pm * remove leftovers from master update * fix alert tests * [Telemetry Checker] TS4 Fixes * bump to 4.0.1-rc * fix new errors in master * bump typescript-eslint to version supporting TS v4 syntax * fix merge commit errors * update to the stable TS version 4.0.2 * bump ts-eslint to version supporting ts v4 * fix typo * fix type errors after merge * update ts in another new package.json * TEMP: remove me * Revert "TEMP: remove me" This reverts commit dc0fc3b. * [Telemetry] Update snapshot for new TS4 SyntaxKind * bump prettier to support TS v4 syntax * fix prettier rules * last style change * fix new type errors Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> # Conflicts: # packages/kbn-i18n/package.json # x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx # x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
mshustov
added a commit
that referenced
this pull request
Aug 27, 2020
* bump ts to v4 * MOAR RAM * fix type errors for OSS * first pass on x-pack errors * second pass on x-pack type errors * 3rd pass on x-pack type-errors * mute errors if complex cases * don't delete if spread suffices * mute other complex cases * make User fields optional * fix optional types * fix tests * fix typings for time_range * fix type errors in x-pack/tests * rebuild kbn-pm * remove leftovers from master update * fix alert tests * [Telemetry Checker] TS4 Fixes * bump to 4.0.1-rc * fix new errors in master * bump typescript-eslint to version supporting TS v4 syntax * fix merge commit errors * update to the stable TS version 4.0.2 * bump ts-eslint to version supporting ts v4 * fix typo * fix type errors after merge * update ts in another new package.json * TEMP: remove me * Revert "TEMP: remove me" This reverts commit dc0fc3b. * [Telemetry] Update snapshot for new TS4 SyntaxKind * bump prettier to support TS v4 syntax * fix prettier rules * last style change * fix new type errors Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> # Conflicts: # packages/kbn-i18n/package.json # x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx # x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/
Closes: #71932
Preparatory work for #72280
Known problems
delete propertyreports an error if the property is not optional. It's okay to mute such errors in tests. In other places I did my best to fix types, remaining issues could be addressed by code owners (in follow-ups)useKibanainterface might need to be changed to separate required core service and optional plugin API. For now, I declare all the required services manually.