Skip to content

[7.9] [SIEM][Timelines] Updates timeline template callout text (#73334)#73417

Merged
MadameSheema merged 1 commit intoelastic:7.9from
MadameSheema:backport/7.9/pr-73334
Jul 28, 2020
Merged

[7.9] [SIEM][Timelines] Updates timeline template callout text (#73334)#73417
MadameSheema merged 1 commit intoelastic:7.9from
MadameSheema:backport/7.9/pr-73334

Conversation

@MadameSheema
Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema commented Jul 28, 2020

Backports the following commits to 7.9:

@MadameSheema @elasticmachine
[SIEM][Timelines] Updates timeline template callout text (elastic#73334)
a4e0a1b 
* updates timeline template callout text

* fixes typo in constant

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MadameSheema MadameSheema added the backport This PR is a backport of another PR label Jul 28, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 28, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / "after each" hook for "toggles open the timeline".timeline flyout button "after each" hook for "toggles open the timeline"

Link to Jenkins

Stack Trace

CypressError: Timed out retrying: `cy.click()` could not be issued because this element is currently animating:

`<button class="euiButtonEmpty euiButtonEmpty--text" type="button" data-test-subj="timeline-new">...</button>`

You can fix this problem by:
  - Passing `{force: true}` which disables all error checking
  - Passing `{waitForAnimations: false}` which disables waiting on animations
  - Passing `{animationDistanceThreshold: 20}` which decreases the sensitivity

https://on.cypress.io/element-is-animating

Because this error occurred during a `after each` hook we are skipping the remaining tests in the current suite: `timeline flyout button`
    at cypressErr (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146621:16)
    at cypressErrByPath (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146630:10)
    at Object.throwErrByPath (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:146593:11)
    at Object.ensureElementIsNotAnimating (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:137560:24)
    at ensureNotAnimating (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127434:13)
    at runAllChecks (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127522:9)
    at retryActionability (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:127542:16)
    at tryCatcher (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:9065:23)
    at Function.Promise.attempt.Promise.try (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:6339:29)
    at tryFn (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140680:21)
    at whenStable (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140715:12)
    at http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:140259:16
    at tryCatcher (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:9065:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7000:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7057:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:61141/__cypress/runner/cypress_runner.js:7102:10)

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 6ebdda5 into elastic:7.9 Jul 28, 2020
@MadameSheema MadameSheema deleted the backport/7.9/pr-73334 branch July 28, 2020 10:57
tylersmalley added a commit that referenced this pull request Jul 28, 2020
@tylersmalley
Revert "[SIEM][Timelines] Updates timeline template callout text (#73334
f615e67 
) (#73417)"

This reverts commit 6ebdda5.
@tylersmalley
Copy link
Copy Markdown
Member

tylersmalley commented Jul 28, 2020

This was the first failure of this tests and is now failing on the 7.9 branch. I am not sure why the changes here would result in that failure, but I have reverted it in the meantime.

7.9: f615e67

@tylersmalley
Copy link
Copy Markdown
Member

tylersmalley commented Jul 28, 2020

Re-backported (aee35b8) - security team is skipping the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MadameSheema @kibanamachine @tylersmalley