Skip to content

[KP] fix doc generation for platform code#73407

Merged
mshustov merged 3 commits intoelastic:masterfrom
mshustov:fix-platform-doc-generation
Jul 28, 2020
Merged

[KP] fix doc generation for platform code#73407
mshustov merged 3 commits intoelastic:masterfrom
mshustov:fix-platform-doc-generation

Conversation

@mshustov
Copy link
Copy Markdown
Contributor

@mshustov mshustov commented Jul 28, 2020 •
edited
Loading

  1. Fixes broken doc generation. Interesting that it didn't fail the [KP] use new ES client in SO service #72289 nor master.
  2. Terminates doc generation step if build types step has failed.

@mshustov mshustov added chore Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 28, 2020
@mshustov mshustov requested a review from a team as a code owner July 28, 2020 07:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov mentioned this pull request Jul 28, 2020
Merged
4 tasks
@mshustov mshustov requested a review from a team as a code owner July 28, 2020 09:51
Dosant
Dosant approved these changes Jul 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes in src/dev/run_check_published_api_changes.ts. Issue with missing error exit code if types generation fails should be fixed

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 28, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover
joshdover approved these changes Jul 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Also interested in why this didn't fail before, would like to understand that.

@mshustov mshustov merged commit 4ede075 into elastic:master Jul 28, 2020
@mshustov mshustov deleted the fix-platform-doc-generation branch July 28, 2020 14:51
mshustov added a commit to mshustov/kibana that referenced this pull request Jul 28, 2020
@mshustov
[KP] fix doc generation for platform code (elastic#73407)
a56bb13 
* fix doc generation for platform code

* terminate process if type build failed

* update types
@mshustov mshustov mentioned this pull request Jul 28, 2020
Merged
mshustov added a commit that referenced this pull request Jul 28, 2020
@mshustov
[KP] fix doc generation for platform code (#73407) (#73474)
1042342 
* fix doc generation for platform code

* terminate process if type build failed

* update types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dosant Dosant Dosant approved these changes

+1 more reviewer

@joshdover joshdover joshdover approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mshustov @elasticmachine @kibanamachine @joshdover @Dosant