[Canvas][tech-debt] Kill Recompose:Pure - Part 1#73303
Merged
clintandrewhall merged 6 commits intoelastic:masterfrom Jul 28, 2020
Merged
[Canvas][tech-debt] Kill Recompose:Pure - Part 1#73303clintandrewhall merged 6 commits intoelastic:masterfrom
clintandrewhall merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
approved these changes
Jul 27, 2020
x-pack/plugins/canvas/public/components/datatable/datatable.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jul 28, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Jul 28, 2020
clintandrewhall
added a commit
that referenced
this pull request
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pureHOC fromrecomposehas been overused in our codebase, oftentimes wrapping function components. This PR kills the simpler instances ofpureand applies best practices.