Skip to content

[Ingest Manager] Convert select agent config step to use combo box#73172

Merged
jen-huang merged 10 commits intoelastic:masterfrom
jen-huang:ingest/72865
Jul 28, 2020
Merged

[Ingest Manager] Convert select agent config step to use combo box#73172
jen-huang merged 10 commits intoelastic:masterfrom
jen-huang:ingest/72865

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang commented Jul 23, 2020 •
edited
Loading

Summary

Resolves #72865. This PR implements changes to Add integration > Select agent config step based on design spec.

Screenshots

Fleet enabled, initial view (Default config selected already, step 2 loads automatically):
image

Fleet enabled, dropdown list view:
image

Fleet no enabled/setup, no agents enrolled messaging:
image

Default config already has Endpoint integration, no agent config selected by default:
image

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 23, 2020
@jen-huang jen-huang requested a review from a team July 23, 2020 23:52
@jen-huang jen-huang self-assigned this Jul 23, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 23, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

skh
skh reviewed Jul 27, 2020
View reviewed changes
...tions/ingest_manager/sections/agent_config/create_package_config_page/step_select_config.tsx
`;

const AgentConfigNameColumn = styled(EuiFlexItem)`
max-width: ${(props) => `${((props.grow as number) / 9) * 100}%`};
Copy link
Copy Markdown
Contributor

@skh skh Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this additional calculation needed? Would it make sense to add a comment about it?

Copy link
Copy Markdown
Contributor Author

@jen-huang jen-huang Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the max-width property is added to prevent long config names/descriptions from overflowing the flex items
  2. we build it from the grow property on the flex items because that property changes based on if Fleet is enabled/setup or not (when Fleet is not available, the "agents enrolled" column is not displayed)

Copy link
Copy Markdown
Contributor Author

@jen-huang jen-huang Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed up a change with comments added

skh
skh reviewed Jul 27, 2020
View reviewed changes
...tions/ingest_manager/sections/agent_config/create_package_config_page/step_select_config.tsx
`;

const AgentConfigDescriptionColumn = styled(EuiFlexItem)`
max-width: ${(props) => `${((props.grow as number) / 9) * 100}%`};
Copy link
Copy Markdown
Contributor

@skh skh Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@skh
Copy link
Copy Markdown
Contributor

skh commented Jul 27, 2020

I'm not sure I'm testing this correctly and if I'm seeing the correct behavior:

  • have a fresh install (from yarn es snapshot)
  • create two more agent configurations. In one of them (called "No description" in the screenshots below), deselect system monitoring so it has no integration at all. The other two configurations have system-1 assigned to them:
    image
    image
  • Go to the system integration and click Add system. The "Default config" config is preselected, even though it already has system-1 assigned to it:
    image
    image

From the description in the inital comment, I would have expected that no agent configuration is selected at all.

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 27, 2020

@skh Sorry, I didn't clarify this. "No config selected" is a case that only applies to integrations which are only allowed to be saved once on a config. Currently the only integration with this limitation is Endpoint. For all other integrations, default config should be preselected.

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Jul 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 27, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +2.4KB 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 82d7e7d into elastic:master Jul 28, 2020
@jen-huang jen-huang deleted the ingest/72865 branch July 28, 2020 02:21
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jul 28, 2020
@jen-huang @elasticmachine
[Ingest Manager] Convert select agent config step to use combo box (e…
7867268 
…lastic#73172)

* Initial pass at using combo box instead of selectable for agent configs

* Hide agent count messaging if fleet isn't set up

* Fix types

* Fix i18n

* Fix i18n again

* Add comment explaining styling

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@jen-huang jen-huang mentioned this pull request Jul 28, 2020
Merged
jen-huang added a commit that referenced this pull request Jul 28, 2020
@jen-huang @elasticmachine
[Ingest Manager] Convert select agent config step to use combo box (#…
6187fa6 
…73172) (#73394)

* Initial pass at using combo box instead of selectable for agent configs

* Hide agent count messaging if fleet isn't set up

* Fix types

* Fix i18n

* Fix i18n again

* Add comment explaining styling

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 28, 2020
@gmmorris
Merge branch 'master' into event-log/use-alerts-actions-clients
76c0b24 
* master: (44 commits)
  [Search] add server logs (elastic#72454)
  [SIEM][Timelines] Updates timeline template callout text (elastic#73334)
  Fix App status  flaky test (elastic#72853)
  [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243)
  Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468)
  fix dashboard index pattern race condition (elastic#72899)
  [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255)
  [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238)
  updates cypress to v4.11.0 (elastic#73327)
  [Metrics UI] Saved views bugs (elastic#72518)
  [Ingest Manager] Convert select agent config step to use combo box (elastic#73172)
  Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128)
  [Security Solution][ML] Updates siem group name to security (elastic#73218)
  [Security Solution] Show proper icon for termination status of all processes (elastic#73235)
  [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313)
  [Security solution] Threat hunting test coverage improvements (elastic#73276)
  [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129)
  [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324)
  [dev/build/docker_generator] convert to typescript (elastic#73339)
  [APM] Fix focus map link on service map (elastic#73338)
  ...
@jen-huang jen-huang mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchaulet nchaulet nchaulet approved these changes

+1 more reviewer

@skh skh skh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jen-huang jen-huang

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Reduce height of Agent configuration selection box

5 participants

@jen-huang @elasticmachine @skh @kibanamachine @nchaulet