[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second#72931
Merged
nchaulet merged 2 commits intoelastic:masterfrom Jul 23, 2020
Conversation
…hange instead of config per second
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
approved these changes
Jul 22, 2020
Contributor
jen-huang
left a comment
There was a problem hiding this comment.
Code LGTM, let's make sure to send out an email about the config key changes when this gets merged and backported.
jfsiii
approved these changes
Jul 22, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
LGTM. Left some comments but 👍 to 🚀
Can we add tests for this behavior?
x-pack/plugins/ingest_manager/server/services/agents/checkin/state_new_actions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/server/services/agents/checkin/state_new_actions.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 23, 2020
…hange instead of config per second (elastic#72931)
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Jul 23, 2020
…hange instead of config per second (elastic#72931)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #72072
This PR fix the configuration of agent config rollout, also we moved from a rate limit per second to a number of concurrent config upgrade.
Add a new config variable
xpack.ingestManager.fleet.agentConfigRolloutConcurrency(by default set to 10)Benchmark
I enrolled 2000 agents and triggered a config change
Before that change
After the change with different concurency setup