[field formatters] IP should return - on null or undefined#7257
Merged
jbudz merged 1 commit intoelastic:masterfrom May 20, 2016
Merged
[field formatters] IP should return - on null or undefined#7257jbudz merged 1 commit intoelastic:masterfrom
jbudz merged 1 commit intoelastic:masterfrom
Conversation
|
LGTM |
This was referenced May 20, 2016
jbudz
added a commit
that referenced
this pull request
May 20, 2016
--------- **Commit 1:** [field formatters] IP should return - on null or undefined * Original sha: 959d9cf * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-20T18:34:57Z
jbudz
added a commit
that referenced
this pull request
May 20, 2016
--------- **Commit 1:** [field formatters] IP should return - on null or undefined * Original sha: 959d9cf * Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-20T18:34:57Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null ip addresses were turning into 0.0.0.0 after running through the ip formatter. This changes null/undefined to render as -.
Closes #7182