[src/dev/build] typescript-ify and convert tests to jest#72525
Merged
spalger merged 11 commits intoelastic:masterfrom Jul 23, 2020
Merged
[src/dev/build] typescript-ify and convert tests to jest#72525spalger merged 11 commits intoelastic:masterfrom
spalger merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
Author
|
Have some TS issues to figure out... |
1b2d2c9 to
d1c9ed5
Compare
jbudz
reviewed
Jul 23, 2020
Contributor
There was a problem hiding this comment.
I took a look through the changes, verified the test counts line up in jest, and pulled down the x-pack tar build. If this targets 7.9.0 I want to do a smoke test of all of the builds, I'm okay now if it's 7.9.1.
I'm out of CPU and can run a build EOD , and probably run a million mac updates - or if someone else gives a verbal works for me. Might be able to piece it together earlier, I'll boot the mac up now.
tylersmalley
approved these changes
Jul 23, 2020
| import { ToolingLog } from '@kbn/dev-utils'; | ||
|
|
||
| import { Config, createRunner } from './lib'; | ||
| import * as Tasks from './tasks'; |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime settings pageStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 23, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
Contributor
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 23, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # src/dev/build/build_distributables.js
spalger
added a commit
that referenced
this pull request
Jul 23, 2020
… (#73108) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before working on #71881 I'd like to "pay back" some debt and finish converting the
src/dev/buildmodule to TypeScript and Jest. The functionality is exactly the same, we just have a little less untyped code and fewer mocha tests.Related: #72496