Skip to content

[SECURITY] [Timeline] Raw events not displayed#72387

Merged
XavierM merged 8 commits intoelastic:masterfrom
XavierM:bug-timeline-raw-alert
Jul 20, 2020
Merged

[SECURITY] [Timeline] Raw events not displayed#72387
XavierM merged 8 commits intoelastic:masterfrom
XavierM:bug-timeline-raw-alert

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Jul 20, 2020 •
edited
Loading

Summary

Note to engineers here: Since we changed to use client.query instead of watchQuery to be able to use a hook to fetch our data. We can not take advantage of the apollo cache anymore so we need to use network-only. Click the link for more info apollographql/apollo-client#2061

here full details

Info:

Preconditions:

  • To have ingested events

Steps to reproduce:

  1. Go to Security application
  2. Open timeline toggle
  3. Enter as query: host.name: *
  4. Click on "All" dropdown
  5. Select "Raw events"

Current behaviour:

  • Nothing is displayed

Expected behaviour:

  • Raw events should be displayed

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 20, 2020
@XavierM XavierM requested review from a team as code owners July 20, 2020 00:49
@XavierM XavierM self-assigned this Jul 20, 2020
@patrykkopycinski
Copy link
Copy Markdown
Contributor

patrykkopycinski commented Jul 20, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 20, 2020

ignoring request to update branch, pull request is closed

@patrykkopycinski
Copy link
Copy Markdown
Contributor

patrykkopycinski commented Jul 20, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 20, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
home 510.6KB +37.0B 510.5KB
securitySolution 7.3MB -125.0B 7.3MB
total - -88.0B -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski
patrykkopycinski approved these changes Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything looks good. Thank you @XavierM! Now go and enjoy your holidays 🌴

@XavierM XavierM merged commit a62c62e into elastic:master Jul 20, 2020
@XavierM XavierM mentioned this pull request Jul 20, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Jul 20, 2020
@XavierM @elasticmachine @patrykkopycinski
[SECURITY] [Timeline] Raw events not displayed (elastic#72387)
ad91a87 
* fix nav with no-data

* fix rules action alerts

* fix raw alert event type

* snapshot

* can only use network-only

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
@XavierM XavierM mentioned this pull request Jul 20, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Jul 20, 2020
@XavierM @elasticmachine @patrykkopycinski
[SECURITY] [Timeline] Raw events not displayed (elastic#72387)
0ffef60 
* fix nav with no-data

* fix rules action alerts

* fix raw alert event type

* snapshot

* can only use network-only

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
d9a1b62 
* master: (60 commits)
  [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335)
  [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337)
  [Resolver] no longer pass related event stats to process node component (elastic#72435)
  Revert "skip flaky suite (elastic#72146)"
  [Security Solution] Cleanup endpoint telemetry (elastic#71950)
  Unskip dashboard embeddable rendering tests (elastic#71824)
  [ENDPOINT] Added unerolling status for host. (elastic#72303)
  [Alerting][Connectors] Increase the size of the logos (elastic#72419)
  [SECURITY] [Timeline] Raw events not displayed (elastic#72387)
  [ML] Fixes display of regression stop stats if one is NaN (elastic#72412)
  [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239)
  Fix match phrase and not match phrase comparators (elastic#71850)
  [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040)
  [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152)
  [Resolver] Selector performance (elastic#72380)
  [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026)
  [Ingest Manager] Do not bumb config revision during config creation (elastic#72270)
  [ML] Adding missing index pattern name to new job wizards (elastic#72400)
  [ML] improve annotation flyout performance (elastic#72299)
  [APM] Testing error rate API and restructuring folders (elastic#72257)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
7febd47 
* master: (26 commits)
  [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335)
  [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337)
  [Resolver] no longer pass related event stats to process node component (elastic#72435)
  Revert "skip flaky suite (elastic#72146)"
  [Security Solution] Cleanup endpoint telemetry (elastic#71950)
  Unskip dashboard embeddable rendering tests (elastic#71824)
  [ENDPOINT] Added unerolling status for host. (elastic#72303)
  [Alerting][Connectors] Increase the size of the logos (elastic#72419)
  [SECURITY] [Timeline] Raw events not displayed (elastic#72387)
  [ML] Fixes display of regression stop stats if one is NaN (elastic#72412)
  [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239)
  Fix match phrase and not match phrase comparators (elastic#71850)
  [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040)
  [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152)
  [Resolver] Selector performance (elastic#72380)
  [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026)
  [Ingest Manager] Do not bumb config revision during config creation (elastic#72270)
  [ML] Adding missing index pattern name to new job wizards (elastic#72400)
  [ML] improve annotation flyout performance (elastic#72299)
  [APM] Testing error rate API and restructuring folders (elastic#72257)
  ...
patrykkopycinski added a commit that referenced this pull request Jul 20, 2020
@XavierM @elasticmachine @patrykkopycinski
[SECURITY] [Timeline] Raw events not displayed (#72387) (#72459)
1918f37 
* fix nav with no-data

* fix rules action alerts

* fix raw alert event type

* snapshot

* can only use network-only

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
patrykkopycinski pushed a commit that referenced this pull request Jul 20, 2020
@XavierM
[SECURITY] [Timeline] Raw events not displayed (#72387) (#72462)
2f70933
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 21, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
c44b626 
…feature-privileges

* alerting/consumer-based-rbac: (45 commits)
  fixed alerts test
  [SIEM][Detection Engine][Lists] Adds list permissions (elastic#72335)
  [SIEM][Detection Engine][Lists] Adds conflict versioning and io-ts improvements to lists (elastic#72337)
  [Resolver] no longer pass related event stats to process node component (elastic#72435)
  Revert "skip flaky suite (elastic#72146)"
  [Security Solution] Cleanup endpoint telemetry (elastic#71950)
  Unskip dashboard embeddable rendering tests (elastic#71824)
  [ENDPOINT] Added unerolling status for host. (elastic#72303)
  [Alerting][Connectors] Increase the size of the logos (elastic#72419)
  [SECURITY] [Timeline] Raw events not displayed (elastic#72387)
  [ML] Fixes display of regression stop stats if one is NaN (elastic#72412)
  [Ingest Pipelines] Processor Editor Move Tooltip (elastic#72239)
  Fix match phrase and not match phrase comparators (elastic#71850)
  [Plugin Generator] Generate tsconfig and useDefaultBehaviors (elastic#72040)
  [Security Solution][Timeline] Fix timeline styling and createFrom beh… (elastic#72152)
  allow user to disable alert even if they dont have privileges to the underlying action
  [Resolver] Selector performance (elastic#72380)
  [Ingest Manager] Set `_meta` in the index.mappings (elastic#72026)
  [Ingest Manager] Do not bumb config revision during config creation (elastic#72270)
  [ML] Adding missing index pattern name to new job wizards (elastic#72400)
  ...
This was referenced Jul 28, 2020
Merged
Closed
Closed
Closed
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@MadameSheema MadameSheema Awaiting requested review from MadameSheema

Assignees

@XavierM XavierM

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XavierM @patrykkopycinski @elasticmachine @kibanamachine @MindyRS