[ML] Remove DragSelect event handlers and selectors on the swim lane unmount #72250
Merged
darnautov merged 3 commits intoelastic:masterfrom Jul 17, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
* master: [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 17, 2020
…unmount (elastic#72250) * [ML] remove selector element on unmount * [ML] stop handler on mount * [ML] remove throttling
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 17, 2020
…unmount (elastic#72250) * [ML] remove selector element on unmount * [ML] stop handler on mount * [ML] remove throttling
This was referenced Jul 17, 2020
Merged
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
…feature-privileges * alerting/consumer-based-rbac: corrected consumer on enable operation [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the EUI upgrade, we assumed there is an issue with an input component. But it just happened by conjuncture with swim lane refactoring to support drag-select in embeddables. Thanks @chandlerprall for spotting the issue with DragSelect handlers' persistence. Presented fix teardowns DragSelect functionality on the swim lane component unmount and removes selector elements from DOM.