chore(NA): teardown dynamic dll plugin by mistic · Pull Request #72096 · elastic/kibana

mistic · 2020-07-16T16:17:51Z

That PR removes the DynamicDllPlugin and all the logic associated with it. After #72017 being merged there is no more node_modules being processed by the legacy optimizer so we can just remove the usage of that plugin.

When we built that plugin more than 2 years ago we did it because we reached a point were we could not live anymore without such a tool. I'm very glad to realise that we did such a long way since then into a point we don't need it anymore!

/cc @elastic/kibana-platform

elasticmachine · 2020-07-16T16:17:54Z

Pinging @elastic/kibana-operations (Team:Operations)

src/optimize/optimize_mixin.ts

pgayvallet

restrry already approved, but for posterity's sake.

tylersmalley · 2020-07-16T16:35:19Z

Can this be removed as well? https://github.com/elastic/kibana/blob/master/packages/kbn-pm/src/config.ts#L34-L45

tylersmalley · 2020-07-16T16:37:17Z

This section can be removed from the build docs: https://github.com/elastic/kibana/blob/master/src/dev/build/README.md#client-node-modules-cleaning

tylersmalley · 2020-07-16T16:38:16Z

One more reference to FORCE_DLL_CREATION https://github.com/elastic/kibana/blob/master/src/dev/build/tasks/optimize_task.js#L44

mistic · 2020-07-16T16:38:27Z

@tylersmalley it probably could but I haven't due to a explanation I also have on that text -> In anyway, have a plugin declaring their own dependencies is the correct and the expect behavior. In the current POC I'm doing with bazel having those plugins expressing their dependencies was very useful to build the single package.json. I think we should keep it.

mistic · 2020-07-16T16:40:53Z

@tylersmalley I've removed all the additional mentions to the DLL work that you've found! Thanks!!

tylersmalley · 2020-07-16T16:43:47Z

The DLL work being removed here was a huge improvement at the time to the developer experience and production optimization. As a reminder, production optimize time was almost 5 minutes and this cut it in half. In the end, it bought us a ton of time to get to where we are at today. 🙇 @mistic

spalger · 2020-07-16T23:45:43Z

@elasticmachine merge upstream

kibanamachine · 2020-07-17T01:41:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 45c695e

Build metrics

✅ unchanged

History

💔 Build #62421 failed f610aa8
💔 Build #62382 failed bba58c1
💔 Build #62342 failed 2e80888

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic · 2020-07-17T10:04:05Z

@spalger Thank you for your help!

* chore(NA): teardown dynamic dll plugin * chore(NA): remove missing ts-ignore * chore(NA): remove last mentions to the DLL machinery * chore(NA): update notice file * prevent duplication and searching target/public * remove changes to es-ui code to unblock pr * add node internals override for legacy tests bundle Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/dev/notice/generate_notice_from_source.ts # src/optimize/base_optimizer.js

* master: (214 commits) replacing hard coded links for ela.st (elastic#72240) skip flaky suite (elastic#60865) chore(NA): teardown dynamic dll plugin (elastic#72096) Register navLink actions for declared applications (elastic#72109) Fix value for process.hash.sha256 draggable (elastic#72142) Call setupIngest before fleet_install tests (elastic#72214) [Security Solution][Detections] Better toast errors (elastic#72205) skip flaky suite (elastic#64696) [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137) [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990) [baseline/capture] use high-memory nodes with ramDisks (elastic#71894) skip flaky suite (elastic#77207) [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946) using test_user with minimum privs (elastic#71988) Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924) [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921) [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125) [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423) [Monitoring] Out of the box alert tweaks (elastic#71942) [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976) ...

* master: (55 commits) updates 'External alerts' tab text (elastic#72237) [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037) replacing hard coded links for ela.st (elastic#72240) skip flaky suite (elastic#60865) chore(NA): teardown dynamic dll plugin (elastic#72096) Register navLink actions for declared applications (elastic#72109) Fix value for process.hash.sha256 draggable (elastic#72142) Call setupIngest before fleet_install tests (elastic#72214) [Security Solution][Detections] Better toast errors (elastic#72205) skip flaky suite (elastic#64696) [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137) [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990) [baseline/capture] use high-memory nodes with ramDisks (elastic#71894) skip flaky suite (elastic#77207) [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946) using test_user with minimum privs (elastic#71988) Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924) [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921) [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125) [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423) ...

* chore(NA): teardown dynamic dll plugin * chore(NA): remove missing ts-ignore * chore(NA): remove last mentions to the DLL machinery * chore(NA): update notice file * prevent duplication and searching target/public * remove changes to es-ui code to unblock pr * add node internals override for legacy tests bundle Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/dev/notice/generate_notice_from_source.ts # src/optimize/base_optimizer.js

mistic · 2020-07-17T12:51:46Z

7.x: ce91760

…feature-privileges * alerting/consumer-based-rbac: (56 commits) take into account which features available in the active space updates 'External alerts' tab text (elastic#72237) [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037) replacing hard coded links for ela.st (elastic#72240) skip flaky suite (elastic#60865) chore(NA): teardown dynamic dll plugin (elastic#72096) Register navLink actions for declared applications (elastic#72109) Fix value for process.hash.sha256 draggable (elastic#72142) Call setupIngest before fleet_install tests (elastic#72214) [Security Solution][Detections] Better toast errors (elastic#72205) skip flaky suite (elastic#64696) [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137) [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990) [baseline/capture] use high-memory nodes with ramDisks (elastic#71894) skip flaky suite (elastic#77207) [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946) using test_user with minimum privs (elastic#71988) Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924) [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921) [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125) ...

chore(NA): teardown dynamic dll plugin

92317e2

mistic added chore Team:Operations Kibana-Operations Team build v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 16, 2020

mistic requested review from a team as code owners July 16, 2020 16:17

mistic self-assigned this Jul 16, 2020

mistic added v7.1.0 v7.10.0 and removed v7.1.0 labels Jul 16, 2020

spalger reviewed Jul 16, 2020

View reviewed changes

src/optimize/optimize_mixin.ts Outdated Show resolved Hide resolved

chore(NA): remove missing ts-ignore

9ffd0fc

mshustov approved these changes Jul 16, 2020

View reviewed changes

pgayvallet approved these changes Jul 16, 2020

View reviewed changes

chore(NA): remove last mentions to the DLL machinery

2e80888

tylersmalley approved these changes Jul 16, 2020

View reviewed changes

mistic added v7.10.0 and removed v7.10.0 labels Jul 16, 2020

mistic and others added 3 commits July 16, 2020 18:50

chore(NA): update notice file

bba58c1

Merge branch 'master' of github.com:elastic/kibana into pr/72096

7c20a25

prevent duplication and searching target/public

eb3d62d

mistic requested a review from a team as a code owner July 16, 2020 19:50

remove changes to es-ui code to unblock pr

f610aa8

spalger removed the request for review from a team July 16, 2020 19:53

spalger added 2 commits July 16, 2020 15:15

Merge branch 'master' of github.com:elastic/kibana into pr/72096

d73b010

add node internals override for legacy tests bundle

f2583cd

Merge branch 'master' into teardown-dynamic-dll-plugin

45c695e

mistic merged commit 9296369 into elastic:master Jul 17, 2020

mistic mentioned this pull request Jul 17, 2020

[7.x] chore(NA): teardown dynamic dll plugin (#72096) #72248

Merged

pgayvallet mentioned this pull request Jul 20, 2020

Migrate status page app to core #72017

Merged

2 tasks

kertal mentioned this pull request Aug 13, 2021

Update component-development.md elastic/eui#5028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(NA): teardown dynamic dll plugin#72096

chore(NA): teardown dynamic dll plugin#72096
mistic merged 10 commits intoelastic:masterfrom
mistic:teardown-dynamic-dll-plugin

mistic commented Jul 16, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jul 16, 2020

Uh oh!

Uh oh!

pgayvallet left a comment •

edited

Loading

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

mistic commented Jul 16, 2020

Uh oh!

mistic commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020 •

edited

Loading

Uh oh!

spalger commented Jul 16, 2020

Uh oh!

kibanamachine commented Jul 17, 2020

Uh oh!

mistic commented Jul 17, 2020

Uh oh!

mistic commented Jul 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mistic commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jul 16, 2020

Uh oh!

Uh oh!

pgayvallet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020

Uh oh!

mistic commented Jul 16, 2020

Uh oh!

mistic commented Jul 16, 2020

Uh oh!

tylersmalley commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger commented Jul 16, 2020

Uh oh!

kibanamachine commented Jul 17, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

mistic commented Jul 17, 2020

Uh oh!

mistic commented Jul 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mistic commented Jul 16, 2020 •

edited

Loading

pgayvallet left a comment •

edited

Loading

tylersmalley commented Jul 16, 2020 •

edited

Loading