[status] Rename setting to "status.allowAnonymous"#7205
Merged
rashidkpc merged 1 commit intoelastic:masterfrom May 13, 2016
Merged
[status] Rename setting to "status.allowAnonymous"#7205rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc merged 1 commit intoelastic:masterfrom
Conversation
… as well as statusPage
This was referenced May 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was backporting #7085, I realized that naming the setting "statusPage.allowAnonymous" was conflicting with the "statusPage" plugin (it wasn't a problem in master as it has been renamed "status_page").
As I thought about it, I realized that the setting really applied to more than just the status page, but the status API as well. We discussed on IRC and decided simply to rename it "status.allowAnonymous" instead. This will make backporting #7085 easier anyway because it won't conflict.