Skip to content

[statusPage] Allow unauthenticated users to see status page#7085

Merged
lukasolson merged 6 commits intoelastic:masterfrom
lukasolson:fix/public-status-page
May 10, 2016
Merged

[statusPage] Allow unauthenticated users to see status page#7085
lukasolson merged 6 commits intoelastic:masterfrom
lukasolson:fix/public-status-page

Conversation

@lukasolson
Copy link
Copy Markdown
Contributor

This PR removes the authentication requirement to see the Kibana status page.

@uboness
Copy link
Copy Markdown

uboness commented Apr 29, 2016

why?

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Apr 29, 2016

We talked a bit about this on slack tonight, and the consensus from that discussion at least was:

We make this option configurable, but we leave the default value as true (ie. blocking access). This is consistent with the default behaviors of ES/shield in general, which is that you don't have access unless you explicitly give it.

Handling this type of thing via a generic config value is kind of lame, but it's probably the only practical option in the short term until we have a more robust authorization system built into Kibana itself.

@lukasolson
Copy link
Copy Markdown
Contributor Author

jenkins, test it

@lukasolson lukasolson assigned epixa and unassigned lukasolson May 2, 2016
@epixa
Copy link
Copy Markdown
Contributor

epixa commented May 3, 2016

jenkins, test it

@epixa
Copy link
Copy Markdown
Contributor

epixa commented May 3, 2016

Linting issues here

@epixa epixa assigned lukasolson and unassigned epixa May 3, 2016
@epixa epixa added needs updates and removed review labels May 3, 2016
@lukasolson lukasolson assigned epixa and unassigned lukasolson May 3, 2016
@rashidkpc
Copy link
Copy Markdown
Contributor

statusPage.disableAuth needs to be documented somewhere. It doesn't make sense to put it in the config file since there's no built in auth, should probably go in the docs somewhere.

@epixa
Copy link
Copy Markdown
Contributor

epixa commented May 9, 2016

Though disableAuth is specific to Kibana rather than security - it will affect any plugin that ties into hapi's auth system.

@rashidkpc
Copy link
Copy Markdown
Contributor

I don't want to clutter the config file with references to rarely used settings in any case

@epixa
Copy link
Copy Markdown
Contributor

epixa commented May 9, 2016

Agreed.

@rashidkpc
Copy link
Copy Markdown
Contributor

This seems to work as described, but I would consider removing the double negation implied by disableAuth. Perhaps allowUnauth (almost as bad) or allowAnonymous?

@lukasolson lukasolson assigned lukasolson and unassigned epixa May 9, 2016
@epixa
Copy link
Copy Markdown
Contributor

epixa commented May 9, 2016

I never really understood the whole aversion to negative flags, but if you're both in agreement about it, I certainly don't care. That said, definitely something like allowAnonymous instead of allowUnauth.

@lukasolson lukasolson assigned rashidkpc and unassigned lukasolson May 10, 2016
@rashidkpc
Copy link
Copy Markdown
Contributor

Wait for the build to finish and merge it

@rashidkpc rashidkpc assigned lukasolson and unassigned rashidkpc May 10, 2016
@lukasolson lukasolson merged commit 969c782 into elastic:master May 10, 2016
lukasolson added a commit that referenced this pull request May 13, 2016
---------

**Commit 1:**
[statusPage] Allow unauthenticated users to see status page

* Original sha: 4c59b5e
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-04-28T18:36:16Z

**Commit 2:**
[statusPage] Add config option to disable auth on status page

* Original sha: adaf9a0
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-02T22:45:36Z

**Commit 3:**
Fix linting issues

* Original sha: 04b2693
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-03T00:47:05Z

**Commit 4:**
[statusPage] Rename config option

* Original sha: db971f4
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T18:35:02Z

**Commit 5:**
[statusPage] Add statusPage.allowAnonymous to docs

* Original sha: a55615f
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T18:41:19Z

**Commit 6:**
[statusPage] Better docs explanation for statusPage.allowAnonymous

* Original sha: 4a822f3
* Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T19:50:54Z
@epixa epixa added the v4.6.0 label Jul 21, 2016
@lukasolson lukasolson deleted the fix/public-status-page branch March 27, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants