[statusPage] Allow unauthenticated users to see status page#7085
[statusPage] Allow unauthenticated users to see status page#7085lukasolson merged 6 commits intoelastic:masterfrom
Conversation
|
why? |
|
We talked a bit about this on slack tonight, and the consensus from that discussion at least was: We make this option configurable, but we leave the default value as Handling this type of thing via a generic config value is kind of lame, but it's probably the only practical option in the short term until we have a more robust authorization system built into Kibana itself. |
|
jenkins, test it |
|
jenkins, test it |
|
Linting issues here |
|
|
|
Though disableAuth is specific to Kibana rather than security - it will affect any plugin that ties into hapi's auth system. |
|
I don't want to clutter the config file with references to rarely used settings in any case |
|
Agreed. |
|
This seems to work as described, but I would consider removing the double negation implied by |
|
I never really understood the whole aversion to negative flags, but if you're both in agreement about it, I certainly don't care. That said, definitely something like |
|
Wait for the build to finish and merge it |
--------- **Commit 1:** [statusPage] Allow unauthenticated users to see status page * Original sha: 4c59b5e * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-04-28T18:36:16Z **Commit 2:** [statusPage] Add config option to disable auth on status page * Original sha: adaf9a0 * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-02T22:45:36Z **Commit 3:** Fix linting issues * Original sha: 04b2693 * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-03T00:47:05Z **Commit 4:** [statusPage] Rename config option * Original sha: db971f4 * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T18:35:02Z **Commit 5:** [statusPage] Add statusPage.allowAnonymous to docs * Original sha: a55615f * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T18:41:19Z **Commit 6:** [statusPage] Better docs explanation for statusPage.allowAnonymous * Original sha: 4a822f3 * Authored by Lukas Olson <olson.lukas@gmail.com> on 2016-05-10T19:50:54Z
This PR removes the authentication requirement to see the Kibana status page.