[Lens] Unskip Lens smokescreen test#71986
Merged
wylieconlon merged 1 commit intoelastic:masterfrom Jul 16, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
commented
Jul 16, 2020
| await PageObjects.lens.configureDimension({ | ||
| dimension: | ||
| '[data-test-subj="lnsXY_xDimensionPanel"] [data-test-subj="lns-empty-dimension"]', | ||
| dimension: 'lnsXY_xDimensionPanel > lns-empty-dimension', |
Contributor
Author
There was a problem hiding this comment.
I recently read through the source code for our testSubjects implementation, and found out that these are equivalent.
flash1293
approved these changes
Jul 16, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Code LGTM, did not test locally.
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Jul 16, 2020
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Jul 16, 2020
wylieconlon
pushed a commit
that referenced
this pull request
Jul 16, 2020
wylieconlon
pushed a commit
that referenced
this pull request
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the flakiness in the Lens smokescreen test in two places:
By adding a retry to work around this issue. #71256
I ran 42 successful tests in the flaky test runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/592/
Fixes #71304