Fix float percentiles line chart#71902
Merged
dej611 merged 5 commits intoelastic:masterfrom Jul 20, 2020
Merged
Conversation
spalger
approved these changes
Jul 15, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Not sure about the code in the change, but the fix from the merge bomb that occured in the last PR looks good to me :)
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
reviewed
Jul 17, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Saying goodbye to the issue 👍 , fix works
some questions about the tests before this can be merged
src/plugins/vis_type_vislib/public/vislib/lib/types/point_series.test.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Jul 20, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍 , thx for adapting the tests! Bug is fixed, tested in Chrome & Firefox, works.
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
This was referenced Jul 20, 2020
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Jul 20, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 20, 2020
* master: [Observability] Remove app logos (elastic#72259) Fix float percentiles line chart (elastic#71902) update chromedriver to 84 (elastic#72228) [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354) [Maps] convert SavedGisMap to TS (elastic#72286) [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302) use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908) [Monitoring] Fix issue with ES node detail status (elastic#72298) [SIEM] Updates consumer in export_rule archive (elastic#72324) [kbn/dev-utils] add RunWithCommands utility (elastic#72311) [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000) skip flaky suite (elastic#72339) [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204) [Lens] Fix switching with layers (elastic#71982) [Maps] 7.9 documenation updates (elastic#71893) docs: ✏️ add "Explore underlying data" user docs (elastic#70807) [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215) Fix indentation level in code exploration doc (elastic#72274) register graph usage (elastic#72041) [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)
dej611
added a commit
that referenced
this pull request
Jul 20, 2020
dej611
added a commit
that referenced
this pull request
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with the ID parser for the line chart when percentiles have float values.
Fixes #47000
Checklist