Resolver traverse levels by oatkiller · Pull Request #71887 · elastic/kibana

oatkiller · 2020-07-15T16:11:12Z

Summary

Recreated #71777 due to some sort of github issue

IndexedProcessTree now owns the concern of defining the order of siblings
IsometricTaxiLayout now owns the concept of ariaLevels
added datetime method to process_event model which returns a time in ms since unix epoch for the event
renamed some resolver selectors
added resolver selector: ariaLevel
added 'data' selector: followingSibling (used for aria-flowto)
added resolver selector ariaFlowtoNodeID which takes a nodeID, and returns its following sibling's node id (if that sibling is visible.) By only returning visible siblings, we ensure that aria-flowto will point to an html ID that is in the dom.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

This reverts commit 24c27ee.

michaelolo24 · 2020-07-15T16:42:29Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+  visibleNodesAndEdgeLines,
+  composeSelectors(dataStateSelector, dataSelectors.followingSibling),
+  (visibleNodesAndEdgeLinesAtTime, followingSibling) => {
+    return defaultMemoize((time: number) => {


been thinking about taking advantage of reselect's parametric selectors. siem uses em. /shrug

oatkiller · 2020-07-15T18:31:30Z

x-pack/plugins/security_solution/server/endpoint/routes/resolver/utils/pagination.ts

    const cursor = {
      timestamp: lastResult['@timestamp'],
-      eventID: eventId(lastResult),
+      eventID: eventId(lastResult) === undefined ? '' : String(eventId(lastResult)),


@jonathan-buttner if this is cool, can i get a re-thumb? ty

oatkiller · 2020-07-15T19:49:36Z

made sure it still works after addressing comments

kibanamachine · 2020-07-15T20:18:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3effa8b

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	9.3MB	+1.9KB	9.3MB

History

💚 Build #61970 succeeded 7b5b69c
💚 Build #61963 succeeded ab85820

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…1887) * `IndexedProcessTree` now owns the concern of defining the order of siblings * `IsometricTaxiLayout` now owns the concept of `ariaLevels` * added `datetime` method to `process_event` model which returns a time in ms since unix epoch for the event * renamed some resolver selectors * added resolver selector: `ariaLevel` * added 'data' selector: `followingSibling` (used for aria-flowto) * added resolver selector `ariaFlowtoNodeID` which takes a nodeID, and returns its following sibling's node id (if that sibling is visible.) By only returning visible siblings, we ensure that `aria-flowto` will point to an html ID that is in the dom.

…71953) * `IndexedProcessTree` now owns the concern of defining the order of siblings * `IsometricTaxiLayout` now owns the concept of `ariaLevels` * added `datetime` method to `process_event` model which returns a time in ms since unix epoch for the event * renamed some resolver selectors * added resolver selector: `ariaLevel` * added 'data' selector: `followingSibling` (used for aria-flowto) * added resolver selector `ariaFlowtoNodeID` which takes a nodeID, and returns its following sibling's node id (if that sibling is visible.) By only returning visible siblings, we ensure that `aria-flowto` will point to an html ID that is in the dom.

…71959) * `IndexedProcessTree` now owns the concern of defining the order of siblings * `IsometricTaxiLayout` now owns the concept of `ariaLevels` * added `datetime` method to `process_event` model which returns a time in ms since unix epoch for the event * renamed some resolver selectors * added resolver selector: `ariaLevel` * added 'data' selector: `followingSibling` (used for aria-flowto) * added resolver selector `ariaFlowtoNodeID` which takes a nodeID, and returns its following sibling's node id (if that sibling is visible.) By only returning visible siblings, we ensure that `aria-flowto` will point to an html ID that is in the dom.

* master: (37 commits) [Lens] Handle failing existence check (elastic#70718) [Security Solution]Fix in-app links and popup window text (elastic#71403) [esArchiver] automatically retry if alias creation fails (elastic#71910) Move data stream index pattern creation test to xpack (elastic#71511) [Maps] Improve language for mvt card (elastic#71947) [Security][Detections] Unskip failing modal tests (elastic#71969) skip flaky suite (elastic#71987) skip flaky suite (elastic#71979) [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956) rename ilm policy to remove -default (elastic#71952) Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948) skip flaky suite (elastic#71971) skip flaky suite (elastic#71951) [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940) skip flaky suite (elastic#71867) [ML] Fix new job with must_not saved search (elastic#71831) [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754) Cleanup (elastic#71849) [Resolver] aria-level and aria-flowto support enhancements (elastic#71887) skip flaky suite (elastic#71304) ...

…feature-privileges * alerting/consumer-based-rbac: (491 commits) [Lens] Handle failing existence check (elastic#70718) [Security Solution]Fix in-app links and popup window text (elastic#71403) [esArchiver] automatically retry if alias creation fails (elastic#71910) Move data stream index pattern creation test to xpack (elastic#71511) [Maps] Improve language for mvt card (elastic#71947) [Security][Detections] Unskip failing modal tests (elastic#71969) skip flaky suite (elastic#71987) skip flaky suite (elastic#71979) [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956) rename ilm policy to remove -default (elastic#71952) Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948) skip flaky suite (elastic#71971) skip flaky suite (elastic#71951) [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940) skip flaky suite (elastic#71867) [ML] Fix new job with must_not saved search (elastic#71831) [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754) Cleanup (elastic#71849) [Resolver] aria-level and aria-flowto support enhancements (elastic#71887) skip flaky suite (elastic#71304) ...

oatkiller added 13 commits July 15, 2020 11:44

WIP

80d2271

buttner test

ec9919b

revert me, too ambitious

06e9774

Revert "revert me, too ambitious"

18fb555

This reverts commit 24c27ee.

draft?

2660109

fix and add tests

bac5645

test

d5138f6

tests

065aade

fixup

2238e5f

fixup

3d724c0

tests

03efa7e

fix sort

ad3abea

fixup

ab85820

oatkiller requested review from a team as code owners July 15, 2020 16:11

oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 15, 2020

oatkiller requested review from jonathan-buttner and michaelolo24 July 15, 2020 16:11

oatkiller mentioned this pull request Jul 15, 2020

[Resolver] aria-level and aria-flowto support enhancements #71777

Closed

2 tasks

oatkiller added 3 commits July 15, 2020 12:14

only brent really knows

9a8d3e6

use instance id in html id generator

96587b2

remove Crumb language

7b5b69c

oatkiller requested a review from kqualters-elastic July 15, 2020 16:19

michaelolo24 reviewed Jul 15, 2020

View reviewed changes

michaelolo24 approved these changes Jul 15, 2020

View reviewed changes

oatkiller force-pushed the resolver-traverse-levels branch 3 times, most recently from 9662220 to ab85820 Compare July 15, 2020 16:49

use empty string in the be

3effa8b

oatkiller commented Jul 15, 2020

View reviewed changes

jonathan-buttner approved these changes Jul 15, 2020

View reviewed changes

oatkiller merged commit 05b0789 into elastic:master Jul 15, 2020

oatkiller deleted the resolver-traverse-levels branch July 15, 2020 20:35

oatkiller mentioned this pull request Jul 15, 2020

[7.9] [Resolver] aria-level and aria-flowto support enhancements (#71887) #71953

Merged

oatkiller mentioned this pull request Jul 15, 2020

[7.x] [Resolver] aria-level and aria-flowto support enhancements (#71887) #71959

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolver traverse levels#71887

Resolver traverse levels#71887
oatkiller merged 17 commits intoelastic:masterfrom
oatkiller:resolver-traverse-levels

oatkiller commented Jul 15, 2020

Uh oh!

michaelolo24 Jul 15, 2020

Uh oh!

oatkiller Jul 15, 2020

Uh oh!

oatkiller Jul 15, 2020

Uh oh!

oatkiller commented Jul 15, 2020

Uh oh!

kibanamachine commented Jul 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

oatkiller commented Jul 15, 2020

Summary

Checklist

For maintainers

Uh oh!

michaelolo24 Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

oatkiller Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

oatkiller Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

oatkiller commented Jul 15, 2020

Uh oh!

kibanamachine commented Jul 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants