[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911)#71355
Merged
spalger merged 1 commit intoelastic:7.xfrom Jul 10, 2020
Merged
[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911)#71355spalger merged 1 commit intoelastic:7.xfrom
spalger merged 1 commit intoelastic:7.xfrom
Conversation
…lastic#70911) Co-authored-by: Josh Dover <me@joshdover.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap # src/plugins/embeddable/kibana.json # src/plugins/telemetry/kibana.json # src/plugins/ui_actions/kibana.json # x-pack/plugins/apm/kibana.json # x-pack/plugins/upgrade_assistant/kibana.json
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
brianseeders
added a commit
that referenced
this pull request
Jul 11, 2020
spalger
added a commit
that referenced
this pull request
Jul 11, 2020
Contributor
Author
|
Reverted the revert, this PR is tricky because it requires that the imports between plugins are encoded in the kibana.json files. The merge timing right before a long weekend was intentional so that I could watch as failures came in, fix things, and on Monday when everyone gets back to work they'll have to merge upstream to deal with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: