[Security Solution] Add 3rd level breadcrumb to admin page by parkiino · Pull Request #71275 · elastic/kibana

parkiino · 2020-07-09T16:58:19Z

Summary

Adds additional breadcrumbs for the administration subapp (hosts and policies)
Additionally renames some more things from management to admin

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…rumbs

elasticmachine · 2020-07-13T20:37:38Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-07-13T20:37:40Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

aisantos

lgtm;

kevinlog · 2020-07-13T21:57:41Z

this looks good to me, but I want @paul-tavares to review before merging this in for 7.9. Worst case, we just merge in 8.0 and backport after the 7.9 branch is cut.

Thanks for putting up the PR @parkiino !

kibanamachine · 2020-07-13T22:17:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: baef12d

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	825	+3	822

History

💚 Build #60902 succeeded 36e34d2
💚 Build #60488 succeeded 1f6bdae
💔 Build #60500 failed b4b87d9
💔 Build #60407 failed 4df5aa7
💔 Build #60338 failed 661c4ad

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares · 2020-07-13T23:46:17Z

x-pack/plugins/security_solution/public/common/components/navigation/breadcrumbs/index.ts

+const isAdminRoutes = (spyState: RouteSpyState): spyState is AdministrationRouteSpyState =>
+  spyState != null && spyState.pageName === SecurityPageName.administration;
+
+// eslint-disable-next-line complexity


Curious what the ESLint error was here.

paul-tavares · 2020-07-13T23:52:07Z

x-pack/plugins/security_solution/public/management/components/management_page_view.tsx

    return [
      {
-        name: i18n.translate('xpack.securitySolution.managementTabs.endpoints', {
+        name: i18n.translate('xpack.securitySolution.managementTabs.hosts', {


I see you created a translations.ts module under management/common/ where both Host and Policies tab names are defined - should they be used here as well?

paul-tavares · 2020-07-13T23:54:03Z

...ugins/security_solution/public/management/pages/endpoint_hosts/view/details/host_details.tsx

    state: {
      onDoneNavigateTo: [
-        'securitySolution:management',
+        'securitySolution:administration',


This should actually be replaced with the constant we have in management/common/constants: MANAGEMENT_APP_ID

paul-tavares · 2020-07-13T23:54:37Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

      state: {
        onCancelNavigateTo: [
-          'securitySolution:management',
+          'securitySolution:administration',


Same here and other places below - use MANAGEMENT_APP_ID

paul-tavares · 2020-07-13T23:55:47Z

x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx

      const navigateToAppMockedCalls = coreStart.application.navigateToApp.mock.calls;
      expect(navigateToAppMockedCalls[navigateToAppMockedCalls.length - 1]).toEqual([
-        'securitySolution:management',
+        'securitySolution:administration',


:-)
Here as well (maybe global search and replace under security_solution/public dir

paul-tavares · 2020-07-13T23:57:52Z

x-pack/plugins/security_solution/public/management/pages/index.tsx

+  let breadcrumb = [
+    {
+      text: ADMINISTRATION,
+      href: getUrlForApp(`${APP_ID}:${SecurityPageName.administration}`, {


use MANAGEMENT_APP_ID instead here

paul-tavares · 2020-07-13T23:59:15Z

x-pack/plugins/security_solution/public/plugin.tsx


    core.application.register({
-      id: `${APP_ID}:${SecurityPageName.management}`,
+      id: `${APP_ID}:${SecurityPageName.administration}`,


maybe we should use the management const here too MANAGEMENT_APP_ID

paul-tavares · 2020-07-13T23:59:45Z

x-pack/plugins/security_solution/server/plugin.ts

  `${APP_ID}:${SecurityPageName.timelines}`,
  `${APP_ID}:${SecurityPageName.case}`,
-  `${APP_ID}:${SecurityPageName.management}`,
+  `${APP_ID}:${SecurityPageName.administration}`,


and here :)

paul-tavares

Thanks for working on this. Nice job 👍 ⭐

All of my comment can be done in a separate PR as they are minor and really should not hold this up.
I would suggest that the description of this PR (and ultimately the Squash and Merge commit message) be clearer around the changes made. I think the bulk of the changes were refactoring ++ bug fix (I think?) around the renaming of the Management tab to Administration (Do I have that right?)

…1275) [Endpoint Security] Add 3rd level (hosts / policies) breadcrumb to admin page

* master: (314 commits) [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) Search across spaces (elastic#67644) ...

…t-apps-page-titles * 'master' of github.com:elastic/kibana: (88 commits) [ML] Functional tests - disable DFA creation and cloning tests [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) [SIEM][Detection Engine][Lists] Adds the ability for exception lists to be multi-list queried. (elastic#71540) initial telemetry setup (elastic#69330) [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (elastic#67027) ... # Conflicts: # x-pack/plugins/index_management/public/application/index.tsx

* master: (72 commits) [test] Skips test preventing promotion of ES snapshot elastic#71612 [Logs UI] Remove UUID from Alert Instances (elastic#71340) [Metrics UI] Remove UUID from Alert Instance IDs (elastic#71335) [ML] Functional tests - disable DFA creation and cloning tests [APM] Use status_code field to calculate error rate (elastic#71109) [Observability] Change appLink passing the date range (elastic#71259) [Security] Add Timeline improvements (elastic#71506) adjust vislib bar opacity (elastic#71421) Fix ScopedHistory mock and adapt usages (elastic#71404) [Security Solution] Add hook for reading/writing resolver query params (elastic#70809) [APM] Bug fixes from ML integration testing (elastic#71564) [Discover] Add caused_by.type and caused_by.reason to error toast modal (elastic#70404) [Security Solution] Add 3rd level breadcrumb to admin page (elastic#71275) [Security Solution][Exceptions] Exception modal bulk close alerts that match exception attributes (elastic#71321) Change signal.rule.risk score mapping from keyword to float (elastic#71126) Added help text where needed on connectors and alert actions UI (elastic#69601) [SIEM][Detections] Value Lists Management Modal (elastic#67068) [test] Skips test preventing promotion of ES snapshot elastic#71582 [test] Skips test preventing promotion of ES snapshot elastic#71555 [ILM] Fix alignment of the timing field (elastic#71273) ...

…71592) [Endpoint Security] Add 3rd level (hosts / policies) breadcrumb to admin page

parkiino added 11 commits July 8, 2020 18:15

some random stuff

8b41d4b

Merge remote-tracking branch 'upstream/master' into task/admin-breadc…

d57c13d

…rumbs

basic working breadcrumbs

661c4ad

typecheck fix, mgmt -> admin

4df5aa7

fix tests

1f6bdae

Merge remote-tracking branch 'upstream/master' into task/admin-breadc…

b4b87d9

…rumbs

Merge remote-tracking branch 'upstream/master' into task/admin-breadc…

6b057cf

…rumbs

Merge remote-tracking branch 'upstream/master' into task/admin-breadc…

07e9edd

…rumbs

fix tests

36e34d2

mgmt > admin

5b58de0

Merge remote-tracking branch 'upstream/master' into task/admin-breadc…

baef12d

…rumbs

parkiino marked this pull request as ready for review July 13, 2020 20:37

parkiino requested review from a team as code owners July 13, 2020 20:37

parkiino added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.9.0 v8.0.0 labels Jul 13, 2020

aisantos approved these changes Jul 13, 2020

View reviewed changes

paul-tavares reviewed Jul 13, 2020

View reviewed changes

paul-tavares approved these changes Jul 14, 2020

View reviewed changes

parkiino changed the title ~~Task/admin breadcrumbs~~ [Security Solution] Add 3rd level breadcrumb to admin page Jul 14, 2020

parkiino merged commit b7a6cff into elastic:master Jul 14, 2020

parkiino deleted the task/admin-breadcrumbs branch July 14, 2020 04:00

parkiino mentioned this pull request Jul 14, 2020

[7.x] [Security Solution] Add 3rd level breadcrumb to admin page (#71275) #71592

Merged

parkiino added a commit to parkiino/kibana that referenced this pull request Jul 14, 2020

[Security Solution] Add 3rd level breadcrumb to admin page (elastic#7…

ff97f0a

…1275) [Endpoint Security] Add 3rd level (hosts / policies) breadcrumb to admin page

parkiino added a commit that referenced this pull request Jul 14, 2020

[Security Solution] Add 3rd level breadcrumb to admin page (#71275) (#…

9925cfe

…71592) [Endpoint Security] Add 3rd level (hosts / policies) breadcrumb to admin page

Conversation

parkiino commented Jul 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 13, 2020

Uh oh!

elasticmachine commented Jul 13, 2020

Uh oh!

aisantos left a comment

Choose a reason for hiding this comment

Uh oh!

kevinlog commented Jul 13, 2020

Uh oh!

kibanamachine commented Jul 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

parkiino commented Jul 9, 2020 •

edited

Loading