Improve failure reporting output for functional tests#70954
Merged
dej611 merged 4 commits intoelastic:masterfrom Jul 9, 2020
Merged
Improve failure reporting output for functional tests#70954dej611 merged 4 commits intoelastic:masterfrom
dej611 merged 4 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Contributor
|
@dej611 is this ready for review? It's still in draft mode but I'm excited to get it. If you're ready click that "ready for review" button :) |
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Jul 9, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611
added a commit
that referenced
this pull request
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains some improvement in case of failures during the functional tests run: in particular when multiple tests are failing the reporter is only showing the number of failures, and to find which test has failed is a process of scrolling the log and look for the "fail" red word.
The alternative method was to use the
--bailflag to stop at the first failure.The improvement in this PR improves the investigation process by integrating the full error message into the custom reporter from
mochaand show a short summary of the failures details at the end of the run.This should simplify the process of debugging failing tests.
mochaerror message and format it properlyBefore
Error inline:
mochawas printing the Error breaking the format in the logger as shown below.Final summary: it shows how many test failed, but not which ones.
After
Error inline: it shows the Error with the right format.
Final summary: after the numbers also details on the name of the failed tests are shown.
Checklist
Delete any items that are not applicable to this PR.