Allow creating filters from fields with null values in discover#70936
Merged
lizozom merged 11 commits intoelastic:masterfrom Jul 9, 2020
Merged
Allow creating filters from fields with null values in discover#70936lizozom merged 11 commits intoelastic:masterfrom
lizozom merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
commented
Jul 7, 2020
src/plugins/data/common/index_patterns/index_patterns/flatten_hit.ts
Outdated
Show resolved
Hide resolved
lukasolson
requested changes
Jul 7, 2020
Contributor
lukasolson
left a comment
There was a problem hiding this comment.
In playing around with this PR, I noticed that we aren't properly handling the case where the value is an array of multiple null values:
I also noticed that for missing fields, we don't show the add inclusive/exclusive filter buttons. We should probably make the behavior the same (show the filter buttons for adding exists/not exists filters).
src/plugins/data/common/index_patterns/index_patterns/flatten_hit.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/query/filter_manager/lib/generate_filters.ts
Outdated
Show resolved
Hide resolved
…ers.ts Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Contributor
Author
|
@elasticmachine merge upstream |
Allow filtering by a non existing field in the doc simplify flatten hit logic
Contributor
Author
|
@lukasolson resolved both issue you had suggested 🙇♀️ |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Jul 9, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code Owner code LGTM 👍 , tested locally in Chrome, Firefox, Safari, MacOS 10.14.6. That a Filter For action for null/undefined value creates a "NOT exists" made me dizzy 💫 at the start, but it makes sense.
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Jul 9, 2020
…tic#70936) * Fix bug elastic#7189 * typo * Test adjustments * wait for load complete * Fine tune test * Update src/plugins/data/public/query/filter_manager/lib/generate_filters.ts Co-authored-by: Lukas Olson <olson.lukas@gmail.com> * Fix filtering by an array of nulls Allow filtering by a non existing field in the doc simplify flatten hit logic Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
lizozom
added a commit
that referenced
this pull request
Jul 13, 2020
…#70936) (#71211) * Allow creating filters from fields with null values in discover (#70936) * Fix bug #7189 * typo * Test adjustments * wait for load complete * Fine tune test * Update src/plugins/data/public/query/filter_manager/lib/generate_filters.ts Co-authored-by: Lukas Olson <olson.lukas@gmail.com> * Fix filtering by an array of nulls Allow filtering by a non existing field in the doc simplify flatten hit logic Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * improve test stability Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In discover, allow creating filters from fields with null \ undefined values.
The created filter is a exists filter.
This fix also includes fixing an issue with
flattenHitswhere empty array values are inserted into the field incorrectly.Functional test added as well.
Dev docs
Bug fix for #7189: Allow creating filters from fields with null \ undefined values.
Checklist
Delete any items that are not applicable to this PR.
For maintainers