Skip to content

[Uptime] Ping list body scroll#70781

Merged
shahzad31 merged 2 commits intoelastic:masterfrom
shahzad31:ping-list-body-scroll
Jul 7, 2020
Merged

[Uptime] Ping list body scroll#70781
shahzad31 merged 2 commits intoelastic:masterfrom
shahzad31:ping-list-body-scroll

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Jul 6, 2020 •
edited
Loading

Summary

Fixes: #70782

After: User can scroll over body or use EuiCodeBlock full screen functionality to view in full page

image

@shahzad31 shahzad31 requested a review from andrewvc July 6, 2020 10:19
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 6, 2020
@shahzad31 shahzad31 self-assigned this Jul 6, 2020
@shahzad31 shahzad31 marked this pull request as ready for review July 6, 2020 10:19
@shahzad31 shahzad31 requested a review from a team as a code owner July 6, 2020 10:19
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 6, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 6, 2020

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 changed the title Ping list body scroll [Uptime] Ping list body scroll Jul 6, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 6, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic
Copy link
Copy Markdown
Contributor

justinkambic commented Jul 6, 2020

Are you able to provide a monitor config that will produce this state? I don't think anything I have set up at the moment accurately causes this issue for me to test with.

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Jul 6, 2020

Are you able to provide a monitor config that will produce this state? I don't think anything I have set up at the moment accurately causes this issue for me to test with.

@justinkambic you can use monitor like this

  - type: http
    id: ir-elastic-co
    name: Elastic Investor Relations
    urls: ["https://ir.elastic.co/home/default.aspx"]
    schedule: "@every 60s"
    tags: ["org:elastic"]
    response.include_body_max_bytes: 99999
    response.include_body: always
    check.response:
      body:
        - Latestttt

andrewvc
andrewvc approved these changes Jul 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tried out the demo config, it worked fine. This is a great little tweak to the app.

@shahzad31 shahzad31 merged commit 77e4019 into elastic:master Jul 7, 2020
@shahzad31 shahzad31 deleted the ping-list-body-scroll branch July 7, 2020 07:22
@shahzad31 shahzad31 mentioned this pull request Jul 7, 2020
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jul 7, 2020
@shahzad31
[Uptime] Ping list body scroll (elastic#70781)
a6d4322
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
ae3c7a7 
* master: (53 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into actions/feature
61626a0 
* master: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'actions/feature' into actions/feature-and-rbac
a73fff5 
* actions/feature: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
shahzad31 added a commit that referenced this pull request Jul 7, 2020
@shahzad31
[7.x] [Uptime] Ping list body scroll (#70781) (#70921)
3924fc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees

@shahzad31 shahzad31

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Ping list body content user can't scroll

5 participants

@shahzad31 @elasticmachine @kibanamachine @justinkambic @andrewvc