[Search] Add telemetry for data plugin search service by lukasolson · Pull Request #70677 · elastic/kibana

lukasolson · 2020-07-02T23:12:01Z

Summary

Relies on #69333.
Partially addresses #62964.

Adds telemetry for data plugin search service. It currently tracks the following events:

When a query times out
When a group of queries is explicitly cancelled by the user
When the popup for running queries beyond timeout is shown
When the popup for long running queries is dismissed
When a user runs a group of queries beyond timeout

To do

Add unit tests

…on the server

…-side-search-strategy

delete search explorer

…om/kibana into search/server-side-search-strategy

Resolved

lizozom

LGTM

kibanamachine · 2020-07-15T07:11:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5dc7b16

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
data	204	-1	205

miscellaneous assets size

id	value	diff	baseline
data	397.3KB	+2.2KB	395.2KB
dataEnhanced	78.4KB	+171.0B	78.2KB
upgradeAssistant	22.5KB	-24.0B	22.6KB
total	-	+2.3KB	-

page load bundle size

id	value	diff	baseline
data	1.4MB	+8.7KB	1.4MB
dataEnhanced	177.7KB	+420.0B	177.3KB
total	-	+9.1KB	-

History

💔 Build #61772 failed c6cd551
💔 Build #61756 failed b874ddc
💔 Build #61746 failed d53c86f
💔 Build #61719 failed b5c1262
💔 Build #61498 failed a734ae2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Fix build of example plugin * Fix functional test * Make server strategies sync * Move strategy name into options * docs * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * typos * test cleanup * Update search interceptor tests and abort utils * [Search] Add telemetry for data plugin search service * Add tracking of average query time * Add tests and rename to collectors * Fix TS * Fixed interceptor jest tests * Add to kibana json * docs * Properly use observables rather than only during setup * Update or create * Swallow version conflict errors Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot

* [search] Refactor the way search strategies are registered/retrieved on the server * Fix types and tests and update docs * Fix failing test * Fix build of example plugin * Fix functional test * Make server strategies sync * Move strategy name into options * docs * Remove FE strategies * TypeScript of hell delete search explorer * Fix search interceptor OSS tests * typos * test cleanup * Update search interceptor tests and abort utils * [Search] Add telemetry for data plugin search service * Add tracking of average query time * Add tests and rename to collectors * Fix TS * Fixed interceptor jest tests * Add to kibana json * docs * Properly use observables rather than only during setup * Update or create * Swallow version conflict errors Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [APM] Add error rates to Service Map popovers (elastic#69520) [Security Solution][Detection Engine] - Update exceptions logic (elastic#71512) [Security Solution] Full screen timeline, Collapse event (elastic#71786) [Security Solution][Exception Modal] Create endpoint exception list if it doesn't already exist (elastic#71807) [Detection Rules] Add 7.9 rules (elastic#71808) [Search] Add telemetry for data plugin search service (elastic#70677) Add @elastic/safer-lodash-set as an alternative to lodash.set (elastic#67452) [tests] Temporarily skipped to promote snapshot

chrisronline · 2020-07-20T15:52:59Z

Hey folks,

Looking at this code, it seems the response will also include a total field, even though it does not show up in the interface. I think this is happening because we are seeing a structure like this in the monitoring parity tests:

"search": {
        "successCount": 0,
        "total": 0,
        "errorCount": 0,
        "averageDuration": null
      },

Does this seem right?

TinaHeiligers · 2020-07-21T13:26:40Z

@lukasolson Are you planning to monitor anything via the telemetry service?

lizozom · 2020-07-22T07:29:45Z

@chrisonline, is that a problem?
@TinaHeiligers yes, that's the intention of this PR. Why?

TinaHeiligers · 2020-07-22T15:44:23Z

@lizozom I ask because I don't see an issue in the Telemetry repo asking to update the mapping for this issue. ui-metrics don't have a schema and we need issues requesting an update to the mapping with the shape of the data we are shipping from Kibana.

chrisronline · 2020-07-22T15:48:31Z

@lizozom It's causing an issue with monitoring parity tests between legacy and metricbeat collection. I don't think it is related to the different collection methods, but rather an issue of the data being available sometimes and not always. Ideally, if the total field is returned and indexed when search-telemetry data is available, it should also be present when it's not (but default to 0).

lizozom · 2020-07-27T13:37:18Z

@TinaHeiligers @lukasolson we'll open an issue for that.
@chrisronline not sure what we should be doing: Help us help you! :-)

chrisronline · 2020-07-27T15:42:10Z

@lizozom Sorry, I did some more digging and I'm not sure this has anything to do with this code. I think it's more of a matter of keys colliding when merging telemetry data, which could be a bigger issue, but I'm still looking into it

afharo · 2020-08-17T11:37:53Z

src/plugins/data/server/search/collectors/fetch.ts

+    });
+
+    return response.hits.hits.length
+      ? (response.hits.hits[0]._source as Usage)


This as Usage cast is not true.
_source is returning something like:

{ "references": [], "updated_at": "2020-08-17T10:53:00.318Z", "search-telemetry": { "successCount": 2, "errorCount": 0, "averageDuration": 110 }, "type": "search-telemetry" }

lukasolson and others added 23 commits June 8, 2020 11:35

[search] Refactor the way search strategies are registered/retrieved …

d964c84

…on the server

Fix types and tests and update docs

1452ed5

Fix failing test

c7d6b61

Fix build of example plugin

955bd88

Merge branch 'master' into refactorServerGetStrategy

93b41fe

Fix functional test

b0be2df

Merge branch 'master' of github.com:elastic/kibana into pr/68452

e09429a

Merge branch 'master' of github.com:elastic/kibana into pr/68452

4eb9dd1

Make server strategies sync

b536e74

Merge branch 'master' of github.com:elastic/kibana into search/server…

1c79c1f

…-side-search-strategy

Move strategy name into options

97c456e

docs

239e3a5

Merge branch 'master' of github.com:elastic/kibana into search/server…

cd21c29

…-side-search-strategy

Remove FE strategies

b918556

Merge branch 'master' into search/server-side-search-strategy

dbb943a

Merge branch 'master' of github.com:elastic/kibana into search/server…

823e56a

…-side-search-strategy

TypeScript of hell

ddd0d0e

delete search explorer

Merge branch 'search/server-side-search-strategy' of github.com:lizoz…

aa5958d

…om/kibana into search/server-side-search-strategy

Fix search interceptor OSS tests

a708610

typos

0b97b0e

test cleanup

8897f99

Update search interceptor tests and abort utils

14c4be2

[Search] Add telemetry for data plugin search service

c65cdaf

lukasolson added Feature:Search Querying infrastructure in Kibana Feature:Telemetry v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 2, 2020

lukasolson requested a review from lizozom July 2, 2020 23:12

lukasolson added 3 commits July 13, 2020 17:05

Properly use observables rather than only during setup

e64e807

Update or create

642614a

Swallow version conflict errors

9381b35

lizozom approved these changes Jul 14, 2020

View reviewed changes

lizozom requested a review from rudolf July 14, 2020 07:43

Liza K and others added 6 commits July 14, 2020 19:48

Merge branch 'master' of github.com:elastic/kibana into pr/70677

a734ae2

Merge branch 'master' into search/telemetry

b5c1262

Merge branch 'master' into search/telemetry

d53c86f

Merge branch 'master' into search/telemetry

b874ddc

Merge branch 'master' into search/telemetry

c6cd551

Merge branch 'master' into search/telemetry

5dc7b16

lizozom merged commit 25d143f into elastic:master Jul 15, 2020

lizozom mentioned this pull request Jul 15, 2020

[7.x] [Search] Add telemetry for data plugin search service (#70677) #71826

Merged

lukasolson mentioned this pull request Jul 23, 2020

[Search] Telemetry makes too many requests #73116

Closed

chrisronline mentioned this pull request Jul 27, 2020

[Monitoring] Ensure monitoring bulk uploader and stats api are more closely aligned #73325

Merged

afharo reviewed Aug 17, 2020

View reviewed changes

afharo mentioned this pull request Aug 18, 2020

Fix returned payload by "search" usage collector #75340

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search] Add telemetry for data plugin search service#70677

[Search] Add telemetry for data plugin search service#70677
lizozom merged 45 commits intoelastic:masterfrom
lukasolson:search/telemetry

lukasolson commented Jul 2, 2020 •

edited

Loading

Uh oh!

lizozom left a comment

Uh oh!

kibanamachine commented Jul 15, 2020

Uh oh!

chrisronline commented Jul 20, 2020

Uh oh!

TinaHeiligers commented Jul 21, 2020

Uh oh!

lizozom commented Jul 22, 2020

Uh oh!

TinaHeiligers commented Jul 22, 2020

Uh oh!

chrisronline commented Jul 22, 2020

Uh oh!

lizozom commented Jul 27, 2020

Uh oh!

chrisronline commented Jul 27, 2020

Uh oh!

afharo Aug 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

lukasolson commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

To do

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 15, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

miscellaneous assets size

page load bundle size

History

Uh oh!

chrisronline commented Jul 20, 2020

Uh oh!

TinaHeiligers commented Jul 21, 2020

Uh oh!

lizozom commented Jul 22, 2020

Uh oh!

TinaHeiligers commented Jul 22, 2020

Uh oh!

chrisronline commented Jul 22, 2020

Uh oh!

lizozom commented Jul 27, 2020

Uh oh!

chrisronline commented Jul 27, 2020

Uh oh!

afharo Aug 17, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lukasolson commented Jul 2, 2020 •

edited

Loading