[Lens] Legend config by flash1293 · Pull Request #70619 · elastic/kibana

flash1293 · 2020-07-02T16:02:37Z

Fixes #67310
Fixes #68293
Fixes #71500

This PR completes the legend options in pie and xy charts:

XY chart:

Added display (auto/show/hide): auto means legend is shown if there is more than one series
Added legend position
The position option is disabled if "hide" is selected

Pie chart:

Added legend position
The position option and the "nested" switch are disabled if "hide" is selected

It also moves the pie settings from the layer widget into the toolbar to be consistent with xy chart:

TODOs:

Write tests
Implement for pie charts as well

Expression changes

lens_xy_legendConfig is extended with a new flag showSingleSeries to encode the current "auto" mode in a BWC fashion. Everything else is still available on the expression layer and below.

The pie chart render function takes another argument legendPosition (everything else is already available)

…workspace_panel_wrapper.scss Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

…toolbar

…tions

…into lens/fitting-functions

…tions

mbondyra

I will continue with testing the PR tomorrow. When it comes to the code, I've left two small notes.

x-pack/plugins/lens/public/pie_visualization/render_function.tsx

x-pack/plugins/lens/public/pie_visualization/toolbar.tsx

mbondyra · 2020-07-17T12:06:13Z

@elasticmachine merge upstream

fix wrong merge

mbondyra · 2020-07-17T12:25:40Z

Tested on FF, works fine. I've resolved the conflicts with master, I think it's fine, but @flash1293 feel free to check if I didn't mess up anything.

x-pack/plugins/lens/public/pie_visualization/toolbar.scss

x-pack/plugins/lens/public/pie_visualization/toolbar.tsx

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

x-pack/plugins/lens/public/pie_visualization/toolbar.tsx

… lens/legend-config

flash1293 · 2020-07-21T12:56:05Z

Thanks for the comments and special thanks for the master merge - I think I addressed all comments, @cchaos can you take another look?

ghost · 2020-07-21T13:00:25Z

💚 Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #70619 updated]
Start Time: 2020-07-21T12:55:57.633+0000
Duration: 4 min 25 sec

cchaos

I'm getting duplicate labels for the fill missing values input.

cchaos · 2020-07-21T14:11:30Z

x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx

+                    hasDividers
+                  />
+                </EuiFormRow>
+                <EuiHorizontalRule />


This needs to be outside of the tooltip and form row.

Suggested change

<EuiHorizontalRule />

<EuiHorizontalRule size="s" />

You mean margin="s"?

flash1293 · 2020-07-21T16:08:10Z

Welp, sorry for that @cchaos - I had to resolve a conflict before pushing which I thought was trivial. Of course it wasn't. Should be fixed now.

cchaos

One last thing is that we need to account for that extra button to the left of the data source no longer being there for non-x/y charts. I'll do a follow up PR since you didn't touch any of those files.

flash1293 · 2020-07-22T08:07:42Z

@elasticmachine merge upstream

kibanamachine · 2020-07-22T09:53:03Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 6bfd2c5
Flaky suites:
- xpack-kibana-ciGroup5

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update·ts.alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle updates to an alert schedule by rescheduling the underlying task

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/72803

[00:00:00]       │
[00:00:00]         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] [ilm-history-2-000001] creating index, cause [api], templates [ilm-history], shards [1]/[0]
[00:00:00]         └-: alerting api integration security and spaces enabled
[00:00:00]           │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] moving index [ilm-history-2-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ debg creating space
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[ilm-history-2-000001][0]]])." previous.health="YELLOW" reason="shards started [[ilm-history-2-000001][0]]"
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] moving index [ilm-history-2-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:00]             │ debg created space
[00:00:00]             │ debg creating space
[00:00:01]             │ debg created space
[00:00:01]             │ debg creating space
[00:00:02]             │ debg created space
[00:00:02]             │ debg creating user no_kibana_privileges
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added user [no_kibana_privileges]
[00:00:02]             │ debg created user no_kibana_privileges
[00:00:02]             │ debg creating role no_kibana_privileges
[00:00:02]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added role [no_kibana_privileges]
[00:00:02]             │ debg creating user superuser
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added user [superuser]
[00:00:03]             │ debg created user superuser
[00:00:03]             │ debg creating user global_read
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added user [global_read]
[00:00:03]             │ debg created user global_read
[00:00:03]             │ debg creating role global_read_role
[00:00:03]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added role [global_read_role]
[00:00:03]             │ debg creating user space_1_all
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added user [space_1_all]
[00:00:03]             │ debg created user space_1_all
[00:00:03]             │ debg creating role space_1_all_role
[00:00:03]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1595405321261135425] added role [space_1_all_role]
[00:02:54]           └-: Alerts
[00:02:54]             └-> "before all" hook
[00:08:17]             └-: update
[00:08:17]               └-> "before all" hook
[00:09:09]               └-: space_1_all at space1
[00:09:09]                 └-> "before all" hook
[00:09:09]                 └-> should handle update alert request appropriately
[00:09:09]                   └-> "before each" hook: global before each
[00:09:11]                   │ proc [kibana]   log   [08:48:27.533] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-07-22T08:48:27.531Z","end":"2020-07-22T08:48:27.531Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"a7d874d2-adec-40dd-bd5e-42ad80a659ff","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:a7d874d2-adec-40dd-bd5e-42ad80a659ff: 'abc'","@timestamp":"2020-07-22T08:48:27.531Z","ecs":{"version":"1.5.0"}}
[00:09:12]                   │ proc [kibana]   log   [08:48:28.497] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-07-22T08:48:28.496Z","end":"2020-07-22T08:48:28.496Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"a7d874d2-adec-40dd-bd5e-42ad80a659ff","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:a7d874d2-adec-40dd-bd5e-42ad80a659ff: 'bcd'","@timestamp":"2020-07-22T08:48:28.496Z","ecs":{"version":"1.5.0"}}
[00:09:12]                   └- ✓ pass  (3.2s) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle update alert request appropriately"
[00:09:12]                 └-> should still be able to update when AAD is broken
[00:09:12]                   └-> "before each" hook: global before each
[00:09:16]                   │ proc [kibana]   log   [08:48:32.418] [error][encryptedSavedObjects][plugins] Failed to decrypt "apiKey" attribute: Unsupported state or unable to authenticate data
[00:09:16]                   │ proc [kibana]   log   [08:48:32.418] [error][alerting][alerts][plugins][plugins] update(): Failed to load API key to invalidate on alert 775afc1b-c3e1-4f08-85f3-eb1bcad3710c: Unable to decrypt attribute "apiKey"
[00:09:17]                   └- ✓ pass  (4.8s) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should still be able to update when AAD is broken"
[00:09:17]                 └-> shouldn't update alert from another space
[00:09:17]                   └-> "before each" hook: global before each
[00:09:17]                   │ proc [kibana]   log   [08:48:33.481] [warning][plugins][taskManager][taskManager] [Task Ownership error]: (1) tasks were claimed by Kibana, but (2) tasks were fetched
[00:09:17]                   │ proc [kibana]   log   [08:48:33.518] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-07-22T08:48:33.517Z","end":"2020-07-22T08:48:33.517Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"775afc1b-c3e1-4f08-85f3-eb1bcad3710c","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:775afc1b-c3e1-4f08-85f3-eb1bcad3710c: 'bcd'","@timestamp":"2020-07-22T08:48:33.517Z","ecs":{"version":"1.5.0"}}
[00:09:17]                   │ proc [kibana]   log   [08:48:33.560] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-07-22T08:48:33.559Z","end":"2020-07-22T08:48:33.559Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"3bdf0352-1809-4131-9065-1cffa1a5f0e9","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:3bdf0352-1809-4131-9065-1cffa1a5f0e9: 'bcd'","@timestamp":"2020-07-22T08:48:33.559Z","ecs":{"version":"1.5.0"}}
[00:09:19]                   │ proc [kibana]   log   [08:48:35.442] [warning][api-authorization][plugins][security] User not authorized for "/api/alerts/alert/28aa1448-71cc-4b8e-b0b8-25505a05de08": responding with 404
[00:09:19]                   └- ✓ pass  (2.1s) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 shouldn't update alert from another space"
[00:09:19]                 └-> should handle update alert request appropriately when attempting to change alert type
[00:09:19]                   └-> "before each" hook: global before each
[00:09:21]                   └- ✓ pass  (2.0s) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle update alert request appropriately when attempting to change alert type"
[00:09:21]                 └-> should handle update alert request appropriately when payload is empty and invalid
[00:09:21]                   └-> "before each" hook: global before each
[00:09:21]                   └- ✓ pass  (51ms) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle update alert request appropriately when payload is empty and invalid"
[00:09:21]                 └-> should handle update alert request appropriately when alertTypeConfig isn't valid
[00:09:21]                   └-> "before each" hook: global before each
[00:09:23]                   └- ✓ pass  (2.0s) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle update alert request appropriately when alertTypeConfig isn't valid"
[00:09:23]                 └-> should handle update alert request appropriately when interval schedule is wrong syntax
[00:09:23]                   └-> "before each" hook: global before each
[00:09:23]                   └- ✓ pass  (48ms) "alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle update alert request appropriately when interval schedule is wrong syntax"
[00:09:23]                 └-> should handle updates to an alert schedule by rescheduling the underlying task
[00:09:23]                   └-> "before each" hook: global before each
[00:09:25]                   │ debg --- retry.try error: expected -1034 to be above 1790000
[00:09:25]                   │ debg --- retry.try error: expected -1547 to be above 1790000
[00:09:26]                   │ debg --- retry.try error: expected -2059 to be above 1790000
[00:09:26]                   │ debg --- retry.try error: expected -2572 to be above 1790000
[00:09:27]                   │ debg --- retry.try error: expected -3087 to be above 1790000
[00:09:27]                   │ debg --- retry.try error: expected -3600 to be above 1790000
[00:09:28]                   │ debg --- retry.try error: expected -4114 to be above 1790000
[00:09:28]                   │ debg --- retry.try error: expected -4626 to be above 1790000
[00:09:29]                   │ debg --- retry.try error: expected -5144 to be above 1790000
[00:09:29]                   │ debg --- retry.try error: expected -5657 to be above 1790000
[00:09:30]                   │ debg --- retry.try error: expected -6171 to be above 1790000
[00:09:30]                   │ debg --- retry.try error: expected -6686 to be above 1790000
[00:09:31]                   │ debg --- retry.try error: expected -7199 to be above 1790000
[00:09:31]                   │ debg --- retry.try error: expected -7720 to be above 1790000
[00:09:32]                   │ debg --- retry.try error: expected -8232 to be above 1790000
[00:09:32]                   │ debg --- retry.try error: expected -8750 to be above 1790000
[00:09:33]                   │ debg --- retry.try error: expected -9265 to be above 1790000
[00:09:33]                   │ debg --- retry.try error: expected -9780 to be above 1790000
[00:09:34]                   │ debg --- retry.try error: expected -10293 to be above 1790000
[00:09:34]                   │ debg --- retry.try error: expected -10805 to be above 1790000
[00:09:35]                   │ debg --- retry.try error: expected -11316 to be above 1790000
[00:09:35]                   │ debg --- retry.try error: expected -11829 to be above 1790000
[00:09:36]                   │ debg --- retry.try error: expected -12342 to be above 1790000
[00:09:36]                   │ debg --- retry.try error: expected -12854 to be above 1790000
[00:09:37]                   │ debg --- retry.try error: expected -13366 to be above 1790000
[00:09:38]                   │ debg --- retry.try error: expected -13879 to be above 1790000
[00:09:38]                   │ debg --- retry.try error: expected -14393 to be above 1790000
[00:09:39]                   │ debg --- retry.try error: expected -14905 to be above 1790000
[00:09:39]                   │ debg --- retry.try error: expected -15417 to be above 1790000
[00:09:40]                   │ debg --- retry.try error: expected -15929 to be above 1790000
[00:09:40]                   │ debg --- retry.try error: expected -16443 to be above 1790000
[00:09:41]                   │ debg --- retry.try error: expected -16956 to be above 1790000
[00:09:41]                   │ debg --- retry.try error: expected -17469 to be above 1790000
[00:09:42]                   │ debg --- retry.try error: expected -17983 to be above 1790000
[00:09:42]                   │ debg --- retry.try error: expected -18496 to be above 1790000
[00:09:43]                   │ debg --- retry.try error: expected -19010 to be above 1790000
[00:09:43]                   │ debg --- retry.try error: expected -19521 to be above 1790000
[00:09:44]                   │ debg --- retry.try error: expected -20034 to be above 1790000
[00:09:44]                   │ debg --- retry.try error: expected -20547 to be above 1790000
[00:09:45]                   │ debg --- retry.try error: expected -21062 to be above 1790000
[00:09:45]                   │ debg --- retry.try error: expected -21576 to be above 1790000
[00:09:46]                   │ debg --- retry.try error: expected -22089 to be above 1790000
[00:09:46]                   │ debg --- retry.try error: expected -22602 to be above 1790000
[00:09:47]                   │ debg --- retry.try error: expected -23115 to be above 1790000
[00:09:47]                   │ debg --- retry.try error: expected -23629 to be above 1790000
[00:09:48]                   │ debg --- retry.try error: expected -24141 to be above 1790000
[00:09:48]                   │ debg --- retry.try error: expected -24655 to be above 1790000
[00:09:49]                   │ debg --- retry.try error: expected -25170 to be above 1790000
[00:09:49]                   │ debg --- retry.try error: expected -25686 to be above 1790000
[00:09:50]                   │ debg --- retry.try error: expected -26200 to be above 1790000
[00:09:50]                   │ debg --- retry.try error: expected -26712 to be above 1790000
[00:09:51]                   │ debg --- retry.try error: expected -27227 to be above 1790000
[00:09:51]                   │ debg --- retry.try error: expected -27741 to be above 1790000
[00:09:52]                   │ debg --- retry.try error: expected -28255 to be above 1790000
[00:09:52]                   │ debg --- retry.try error: expected -28769 to be above 1790000
[00:09:53]                   │ debg --- retry.try error: expected -29282 to be above 1790000
[00:09:53]                   │ debg --- retry.try error: expected -29799 to be above 1790000
[00:09:54]                   │ debg --- retry.try error: expected -30316 to be above 1790000
[00:09:54]                   │ debg --- retry.try error: expected -30830 to be above 1790000
[00:09:55]                   │ debg --- retry.try error: expected -31347 to be above 1790000
[00:09:56]                   │ debg --- retry.try error: expected -31864 to be above 1790000
[00:09:56]                   │ debg --- retry.try error: expected -32379 to be above 1790000
[00:09:57]                   │ debg --- retry.try error: expected -32898 to be above 1790000
[00:09:57]                   │ debg --- retry.try error: expected -33414 to be above 1790000
[00:09:58]                   │ debg --- retry.try error: expected -33929 to be above 1790000
[00:09:58]                   │ debg --- retry.try error: expected -34445 to be above 1790000
[00:09:59]                   │ debg --- retry.try error: expected -34958 to be above 1790000
[00:09:59]                   │ debg --- retry.try error: expected -35476 to be above 1790000
[00:10:00]                   │ debg --- retry.try error: expected -35998 to be above 1790000
[00:10:00]                   │ debg --- retry.try error: expected -36515 to be above 1790000
[00:10:01]                   │ debg --- retry.try error: expected -37030 to be above 1790000
[00:10:01]                   │ debg --- retry.try error: expected -37556 to be above 1790000
[00:10:02]                   │ debg --- retry.try error: expected -38073 to be above 1790000
[00:10:02]                   │ debg --- retry.try error: expected -38592 to be above 1790000
[00:10:03]                   │ debg --- retry.try error: expected -39109 to be above 1790000
[00:10:03]                   │ debg --- retry.try error: expected -39621 to be above 1790000
[00:10:04]                   │ debg --- retry.try error: expected -40135 to be above 1790000
[00:10:04]                   │ debg --- retry.try error: expected -40653 to be above 1790000
[00:10:05]                   │ debg --- retry.try error: expected -41172 to be above 1790000
[00:10:05]                   │ debg --- retry.try error: expected -41690 to be above 1790000
[00:10:06]                   │ debg --- retry.try error: expected -42205 to be above 1790000
[00:10:06]                   │ debg --- retry.try error: expected -42720 to be above 1790000
[00:10:07]                   │ debg --- retry.try error: expected -43238 to be above 1790000
[00:10:07]                   │ debg --- retry.try error: expected -43754 to be above 1790000
[00:10:08]                   │ debg --- retry.try error: expected -44270 to be above 1790000
[00:10:08]                   │ debg --- retry.try error: expected -44788 to be above 1790000
[00:10:09]                   │ debg --- retry.try error: expected -45305 to be above 1790000
[00:10:09]                   │ debg --- retry.try error: expected -45818 to be above 1790000
[00:10:10]                   │ debg --- retry.try error: expected -46345 to be above 1790000
[00:10:10]                   │ debg --- retry.try error: expected -46859 to be above 1790000
[00:10:11]                   │ debg --- retry.try error: expected -47373 to be above 1790000
[00:10:12]                   │ debg --- retry.try error: expected -47890 to be above 1790000
[00:10:12]                   │ debg --- retry.try error: expected -48407 to be above 1790000
[00:10:13]                   │ debg --- retry.try error: expected -48923 to be above 1790000
[00:10:13]                   │ debg --- retry.try error: expected -49450 to be above 1790000
[00:10:14]                   │ debg --- retry.try error: expected -49967 to be above 1790000
[00:10:14]                   │ debg --- retry.try error: expected -50481 to be above 1790000
[00:10:15]                   │ debg --- retry.try error: expected -51005 to be above 1790000
[00:10:15]                   │ debg --- retry.try error: expected -51524 to be above 1790000
[00:10:16]                   │ debg --- retry.try error: expected -52044 to be above 1790000
[00:10:16]                   │ debg --- retry.try error: expected -52567 to be above 1790000
[00:10:17]                   │ debg --- retry.try error: expected -53081 to be above 1790000
[00:10:17]                   │ debg --- retry.try error: expected -53596 to be above 1790000
[00:10:18]                   │ debg --- retry.try error: expected -54109 to be above 1790000
[00:10:18]                   │ debg --- retry.try error: expected -54626 to be above 1790000
[00:10:19]                   │ debg --- retry.try error: expected -55139 to be above 1790000
[00:10:19]                   │ debg --- retry.try error: expected -55653 to be above 1790000
[00:10:20]                   │ debg --- retry.try error: expected -56164 to be above 1790000
[00:10:20]                   │ debg --- retry.try error: expected -56679 to be above 1790000
[00:10:21]                   │ debg --- retry.try error: expected -57199 to be above 1790000
[00:10:21]                   │ debg --- retry.try error: expected -57730 to be above 1790000
[00:10:22]                   │ debg --- retry.try error: expected -58249 to be above 1790000
[00:10:22]                   │ debg --- retry.try error: expected -58769 to be above 1790000
[00:10:23]                   │ debg --- retry.try error: expected -59282 to be above 1790000
[00:10:23]                   │ debg --- retry.try error: expected -59795 to be above 1790000
[00:10:24]                   │ debg --- retry.try error: expected -60310 to be above 1790000
[00:10:24]                   │ debg --- retry.try error: expected -60826 to be above 1790000
[00:10:25]                   │ debg --- retry.try error: expected -61344 to be above 1790000
[00:10:25]                   │ debg --- retry.try error: expected -61858 to be above 1790000
[00:10:26]                   │ debg --- retry.try error: expected -62373 to be above 1790000
[00:10:27]                   │ debg --- retry.try error: expected -62888 to be above 1790000
[00:10:27]                   │ debg --- retry.try error: expected -63408 to be above 1790000
[00:10:28]                   │ debg --- retry.try error: expected -63925 to be above 1790000
[00:10:28]                   │ debg --- retry.try error: expected -64442 to be above 1790000
[00:10:29]                   │ debg --- retry.try error: expected -64965 to be above 1790000
[00:10:29]                   │ debg --- retry.try error: expected -65484 to be above 1790000
[00:10:30]                   │ debg --- retry.try error: expected -66001 to be above 1790000
[00:10:30]                   │ debg --- retry.try error: expected -66517 to be above 1790000
[00:10:31]                   │ debg --- retry.try error: expected -67037 to be above 1790000
[00:10:31]                   │ debg --- retry.try error: expected -67559 to be above 1790000
[00:10:32]                   │ debg --- retry.try error: expected -68084 to be above 1790000
[00:10:32]                   │ debg --- retry.try error: expected -68606 to be above 1790000
[00:10:33]                   │ debg --- retry.try error: expected -69125 to be above 1790000
[00:10:33]                   │ debg --- retry.try error: expected -69649 to be above 1790000
[00:10:34]                   │ debg --- retry.try error: expected -70169 to be above 1790000
[00:10:34]                   │ debg --- retry.try error: expected -70684 to be above 1790000
[00:10:35]                   │ debg --- retry.try error: expected -71202 to be above 1790000
[00:10:35]                   │ debg --- retry.try error: expected -71719 to be above 1790000
[00:10:36]                   │ debg --- retry.try error: expected -72238 to be above 1790000
[00:10:36]                   │ debg --- retry.try error: expected -72761 to be above 1790000
[00:10:37]                   │ debg --- retry.try error: expected -73281 to be above 1790000
[00:10:37]                   │ debg --- retry.try error: expected -73800 to be above 1790000
[00:10:38]                   │ debg --- retry.try error: expected -74320 to be above 1790000
[00:10:38]                   │ debg --- retry.try error: expected -74845 to be above 1790000
[00:10:39]                   │ debg --- retry.try error: expected -75364 to be above 1790000
[00:10:40]                   │ debg --- retry.try error: expected -75878 to be above 1790000
[00:10:40]                   │ debg --- retry.try error: expected -76396 to be above 1790000
[00:10:41]                   │ debg --- retry.try error: expected -76914 to be above 1790000
[00:10:41]                   │ debg --- retry.try error: expected -77430 to be above 1790000
[00:10:42]                   │ debg --- retry.try error: expected -77948 to be above 1790000
[00:10:42]                   │ debg --- retry.try error: expected -78468 to be above 1790000
[00:10:43]                   │ debg --- retry.try error: expected -78990 to be above 1790000
[00:10:43]                   │ debg --- retry.try error: expected -79510 to be above 1790000
[00:10:44]                   │ debg --- retry.try error: expected -80044 to be above 1790000
[00:10:44]                   │ debg --- retry.try error: expected -80563 to be above 1790000
[00:10:45]                   │ debg --- retry.try error: expected -81083 to be above 1790000
[00:10:45]                   │ debg --- retry.try error: expected -81601 to be above 1790000
[00:10:46]                   │ debg --- retry.try error: expected -82117 to be above 1790000
[00:10:46]                   │ debg --- retry.try error: expected -82635 to be above 1790000
[00:10:47]                   │ debg --- retry.try error: expected -83155 to be above 1790000
[00:10:47]                   │ debg --- retry.try error: expected -83675 to be above 1790000
[00:10:48]                   │ debg --- retry.try error: expected -84191 to be above 1790000
[00:10:48]                   │ debg --- retry.try error: expected -84708 to be above 1790000
[00:10:49]                   │ debg --- retry.try error: expected -85226 to be above 1790000
[00:10:49]                   │ debg --- retry.try error: expected -85752 to be above 1790000
[00:10:50]                   │ debg --- retry.try error: expected -86276 to be above 1790000
[00:10:50]                   │ debg --- retry.try error: expected -86798 to be above 1790000
[00:10:51]                   │ debg --- retry.try error: expected -87319 to be above 1790000
[00:10:51]                   │ debg --- retry.try error: expected -87841 to be above 1790000
[00:10:52]                   │ debg --- retry.try error: expected -88362 to be above 1790000
[00:10:53]                   │ debg --- retry.try error: expected -88879 to be above 1790000
[00:10:53]                   │ debg --- retry.try error: expected -89398 to be above 1790000
[00:10:54]                   │ debg --- retry.try error: expected -89917 to be above 1790000
[00:10:54]                   │ debg --- retry.try error: expected -90437 to be above 1790000
[00:10:55]                   │ debg --- retry.try error: expected -90956 to be above 1790000
[00:10:55]                   │ debg --- retry.try error: expected -91475 to be above 1790000
[00:10:56]                   │ debg --- retry.try error: expected -91994 to be above 1790000
[00:10:56]                   │ debg --- retry.try error: expected -92520 to be above 1790000
[00:10:57]                   │ debg --- retry.try error: expected -93039 to be above 1790000
[00:10:57]                   │ debg --- retry.try error: expected -93556 to be above 1790000
[00:10:58]                   │ debg --- retry.try error: expected -94083 to be above 1790000
[00:10:58]                   │ debg --- retry.try error: expected -94604 to be above 1790000
[00:10:59]                   │ debg --- retry.try error: expected -95123 to be above 1790000
[00:10:59]                   │ debg --- retry.try error: expected -95641 to be above 1790000
[00:11:00]                   │ debg --- retry.try error: expected -96158 to be above 1790000
[00:11:00]                   │ debg --- retry.try error: expected -96677 to be above 1790000
[00:11:01]                   │ debg --- retry.try error: expected -97201 to be above 1790000
[00:11:01]                   │ debg --- retry.try error: expected -97727 to be above 1790000
[00:11:02]                   │ debg --- retry.try error: expected -98248 to be above 1790000
[00:11:02]                   │ debg --- retry.try error: expected -98775 to be above 1790000
[00:11:03]                   │ debg --- retry.try error: expected -99304 to be above 1790000
[00:11:03]                   │ debg --- retry.try error: expected -99826 to be above 1790000
[00:11:04]                   │ debg --- retry.try error: expected -100349 to be above 1790000
[00:11:05]                   │ debg --- retry.try error: expected -100872 to be above 1790000
[00:11:05]                   │ debg --- retry.try error: expected -101396 to be above 1790000
[00:11:06]                   │ debg --- retry.try error: expected -101917 to be above 1790000
[00:11:06]                   │ debg --- retry.try error: expected -102435 to be above 1790000
[00:11:07]                   │ debg --- retry.try error: expected -102961 to be above 1790000
[00:11:07]                   │ debg --- retry.try error: expected -103486 to be above 1790000
[00:11:08]                   │ debg --- retry.try error: expected -104015 to be above 1790000
[00:11:08]                   │ debg --- retry.try error: expected -104537 to be above 1790000
[00:11:09]                   │ debg --- retry.try error: expected -105061 to be above 1790000
[00:11:09]                   │ debg --- retry.try error: expected -105582 to be above 1790000
[00:11:10]                   │ debg --- retry.try error: expected -106107 to be above 1790000
[00:11:10]                   │ debg --- retry.try error: expected -106631 to be above 1790000
[00:11:11]                   │ debg --- retry.try error: expected -107152 to be above 1790000
[00:11:11]                   │ debg --- retry.try error: expected -107678 to be above 1790000
[00:11:12]                   │ debg --- retry.try error: expected -108204 to be above 1790000
[00:11:12]                   │ debg --- retry.try error: expected -108722 to be above 1790000
[00:11:13]                   │ debg --- retry.try error: expected -109249 to be above 1790000
[00:11:13]                   │ debg --- retry.try error: expected -109770 to be above 1790000
[00:11:14]                   │ debg --- retry.try error: expected -110289 to be above 1790000
[00:11:14]                   │ debg --- retry.try error: expected -110812 to be above 1790000
[00:11:15]                   │ debg --- retry.try error: expected -111329 to be above 1790000
[00:11:15]                   │ debg --- retry.try error: expected -111847 to be above 1790000
[00:11:16]                   │ debg --- retry.try error: expected -112366 to be above 1790000
[00:11:17]                   │ debg --- retry.try error: expected -112892 to be above 1790000
[00:11:17]                   │ debg --- retry.try error: expected -113413 to be above 1790000
[00:11:18]                   │ debg --- retry.try error: expected -113931 to be above 1790000
[00:11:18]                   │ debg --- retry.try error: expected -114451 to be above 1790000
[00:11:19]                   │ debg --- retry.try error: expected -114973 to be above 1790000
[00:11:19]                   │ debg --- retry.try error: expected -115493 to be above 1790000
[00:11:20]                   │ debg --- retry.try error: expected -116012 to be above 1790000
[00:11:20]                   │ debg --- retry.try error: expected -116532 to be above 1790000
[00:11:21]                   │ debg --- retry.try error: expected -117054 to be above 1790000
[00:11:21]                   │ debg --- retry.try error: expected -117574 to be above 1790000
[00:11:22]                   │ debg --- retry.try error: expected -118091 to be above 1790000
[00:11:22]                   │ debg --- retry.try error: expected -118610 to be above 1790000
[00:11:23]                   │ debg --- retry.try error: expected -119133 to be above 1790000
[00:11:23]                   │ debg --- retry.try error: expected -119660 to be above 1790000
[00:11:24]                   │ debg --- retry.try error: expected -120178 to be above 1790000
[00:11:24]                   │ debg --- retry.try error: expected -120700 to be above 1790000
[00:11:25]                   └- ✖ fail: alerting api integration security and spaces enabled Alerts update space_1_all at space1 should handle updates to an alert schedule by rescheduling the underlying task
[00:11:25]                   │      retry.try timeout: Error: expected -120700 to be above 1790000
[00:11:25]                   │     at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
[00:11:25]                   │     at Assertion.greaterThan.Assertion.above (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:317:8)
[00:11:25]                   │     at Function.greaterThan (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:531:15)
[00:11:25]                   │     at ensureDatetimeIsWithinRange (/dev/shm/workspace/kibana/x-pack/test/alerting_api_integration/common/lib/test_assertions.ts:15:22)
[00:11:25]                   │     at retry.try (/dev/shm/workspace/kibana/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts:430:13)
[00:11:25]                   │   Error: retry.try timeout: Error: expected -120700 to be above 1790000
[00:11:25]                   │       at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
[00:11:25]                   │       at Assertion.greaterThan.Assertion.above (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:317:8)
[00:11:25]                   │       at Function.greaterThan (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:531:15)
[00:11:25]                   │       at ensureDatetimeIsWithinRange (test/alerting_api_integration/common/lib/test_assertions.ts:15:22)
[00:11:25]                   │       at retry.try (test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts:430:13)
[00:11:25]                   │       at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
[00:11:25]                   │       at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)
[00:11:25]                   │ 
[00:11:25]                   │

Stack Trace

Error: retry.try timeout: Error: expected -120700 to be above 1790000
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.greaterThan.Assertion.above (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:317:8)
    at Function.greaterThan (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:531:15)
    at ensureDatetimeIsWithinRange (test/alerting_api_integration/common/lib/test_assertions.ts:15:22)
    at retry.try (test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts:430:13)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

Build metrics

page load bundle size

id	value	diff	baseline
lens	840.5KB	+7.3KB	833.2KB

History

💔 Build #63340 failed 7f98197
💚 Build #63268 succeeded 638ebc9
💔 Build #63228 failed bec88ff
💚 Build #62604 succeeded b3cc284
💔 Build #62600 failed 6f2acf1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (34 commits) Adds Role Based Access-Control to the Alerting & Action plugins based on Kibana Feature Controls (elastic#67157) [Monitoring] Revert direct shipping code (elastic#72505) Use server basepath when creating reporting jobs (elastic#72722) Adding api test for transaction_groups /breakdown and /avg_duration_by_browser (elastic#72623) [Task Manager] Addresses flaky test introduced by buffered store (elastic#72815) [Observability] filter "hasData" api by processor event (elastic#72810) do not pass title as part of tsvb request (elastic#72619) [Lens] Legend config (elastic#70619) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) ...

flash1293 and others added 30 commits June 16, 2020 15:22

add toolbar api

bebac29

fix teests

e983014

fix types

3fbff62

fix functional test

426f2ce

Merge remote-tracking branch 'upstream/master' into lens/toolbar

44a17c3

add back title

8c7381e

remove separator line

64ee8ef

Merge remote-tracking branch 'upstream/master' into lens/toolbar

9bb7843

fix i18n

c1ddaaa

Update x-pack/plugins/lens/public/editor_frame_service/editor_frame/_…

e51ff5e

…workspace_panel_wrapper.scss Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

Merge remote-tracking branch 'upstream/master' into lens/toolbar

e3c6f94

Merge branch 'lens/toolbar' of github.com:flash1293/kibana into lens/…

a278772

…toolbar

Merge remote-tracking branch 'upstream/master' into lens/toolbar

bfb6898

Merge remote-tracking branch 'upstream/master' into lens/toolbar

b3fb6e8

do not show unsaved when there is no cahrt

2434486

revert unnecessary changes

85c128e

Merge remote-tracking branch 'upstream/master' into lens/toolbar

1ece895

always show title if available

34cff58

Merge remote-tracking branch 'upstream/master' into lens/toolbar

7a20163

fitting functions

c6cdca0

Merge remote-tracking branch 'upstream/master' into lens/fitting-func…

c0adafc

…tions

clean up implementation

fc6bd1d

Merge branch 'master' into lens/fitting-functions

edf1818

Merge remote-tracking branch 'upstream/master' into lens/fitting-func…

7e744a1

…tions

use compressed form

5d0b6f4

Merge remote-tracking branch 'upstream/master' into lens/fitting-func…

bde6bec

…tions

Merge branch 'lens/fitting-functions' of github.com:flash1293/kibana …

4facefc

…into lens/fitting-functions

Merge remote-tracking branch 'upstream/master' into lens/fitting-func…

3c3a4d6

…tions

fix styling

6d6f8d0

Merge remote-tracking branch 'upstream/master' into lens/fitting-func…

188f3a7

…tions

mbondyra reviewed Jul 16, 2020

View reviewed changes

x-pack/plugins/lens/public/pie_visualization/render_function.tsx Outdated Show resolved Hide resolved

x-pack/plugins/lens/public/pie_visualization/toolbar.tsx Show resolved Hide resolved

Merge branch 'master' into lens/legend-config

e9bcbe6

elasticmachine and others added 2 commits July 17, 2020 06:06

Merge branch 'master' into lens/legend-config

6f2acf1

Update xy_config_panel.tsx

b3cc284

fix wrong merge

mbondyra approved these changes Jul 17, 2020

View reviewed changes

cchaos suggested changes Jul 17, 2020

View reviewed changes

flash1293 added 4 commits July 21, 2020 10:58

Merge remote-tracking branch 'upstream/master' into lens/legend-config

ce31e3b

reviews

947fbc5

Merge branch 'lens/legend-config' of github.com:flash1293/kibana into…

bec88ff

… lens/legend-config

fix translations

638ebc9

cchaos suggested changes Jul 21, 2020

View reviewed changes

flash1293 added 2 commits July 21, 2020 17:52

Merge remote-tracking branch 'upstream/master' into lens/legend-config

10ac06b

fix reviews

0e660ba

remove unused fragment

7f98197

cchaos approved these changes Jul 21, 2020

View reviewed changes

Merge branch 'master' into lens/legend-config

6bfd2c5

flash1293 merged commit 3709de6 into elastic:master Jul 22, 2020

flash1293 deleted the lens/legend-config branch July 22, 2020 10:15

flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 22, 2020

[Lens] Legend config (elastic#70619)

90bc5de

flash1293 mentioned this pull request Jul 22, 2020

[7.x] [Lens] Legend config (#70619) #72821

Merged

flash1293 added a commit that referenced this pull request Jul 22, 2020

[Lens] Legend config (#70619) (#72821)

6c7b914

flash1293 mentioned this pull request Oct 16, 2020

Ability to remove legend of visualizations #34102

Closed

Conversation

flash1293 commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Expression changes

Uh oh!

mbondyra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mbondyra commented Jul 17, 2020

Uh oh!

mbondyra commented Jul 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flash1293 commented Jul 21, 2020

Uh oh!

ghost commented Jul 21, 2020

💚 Build Succeeded

Build stats

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

cchaos Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Jul 21, 2020

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Jul 22, 2020

Uh oh!

kibanamachine commented Jul 22, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flash1293 commented Jul 2, 2020 •

edited

Loading