[APM] Don't fetch dynamic index pattern in setupRequest#70308
Merged
dgieselaar merged 5 commits intoelastic:masterfrom Jul 2, 2020
Merged
[APM] Don't fetch dynamic index pattern in setupRequest#70308dgieselaar merged 5 commits intoelastic:masterfrom
dgieselaar merged 5 commits intoelastic:masterfrom
Conversation
We don't need a dynamic index pattern for parsing the filters from the query bar. Additionally, instead of fetching uiIndices in `getParamsForSearchRequest`, we can use `indices` that we already fetched in `setupRequest`.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
reviewed
Jun 30, 2020
|
|
||
| const ast = esKuery.fromKueryExpression(kuery); | ||
| return esKuery.toElasticsearchQuery(ast, indexPattern) as ESFilter; | ||
| return esKuery.toElasticsearchQuery(ast) as ESFilter; |
Contributor
Author
There was a problem hiding this comment.
I tested it by entering various searches in the query bar, and using the contextual filters.
Contributor
Author
There was a problem hiding this comment.
It says:
* IndexPattern isn't required, but if you pass one in, we can be more intelligent
* about how we craft the queries (e.g. scripted fields)
Sounds like it should be okay for our use case?
Contributor
There was a problem hiding this comment.
yeah, I think I've seen that before and wondered what that actually meant :D
If it's just scripted fields and you did the manual testing it's probably fine
sorenlouv
approved these changes
Jun 30, 2020
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
lgtm if index pattern is not needed for toElasticsearchQuery
Contributor
Author
|
@elasticmachine merge upstream |
…kibana into remove-dynamic-index-pattern
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jul 2, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 2, 2020
* master: Update known-plugins.asciidoc (elastic#69370) [ML] Anomaly Explorer swim lane pagination (elastic#70063) [Ingest Manager] Update asset paths to use _ instead of - (elastic#70320) Fix discover, tsvb and Lens chart theming issues (elastic#69695) Allow Saved Object type mappings to set a field's `doc_values` property (elastic#70433) [S&R] Support data streams (elastic#68078) [Maps] Add styling and tooltip support to mapbox mvt vector tile sources (elastic#64488) redirect to default app if hash can not be forwarded (elastic#70417) [APM] Don't fetch dynamic index pattern in setupRequest (elastic#70308) [Security_Solution][Endpoint] Leveraging msearch and ancestry array for resolver (elastic#70134) Update docs for api authentication usage (elastic#66819) chore(NA): disable alerts_detection_rules cypress suites (elastic#70577) add getVisibleTypes API to SO type registry (elastic#70559)
dgieselaar
added a commit
that referenced
this pull request
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need a dynamic index pattern for parsing the filters from the query bar. Additionally, instead of fetching uiIndices in
getParamsForSearchRequest, we can useindicesthat we already fetched insetupRequest.