Fixed assertion in hybrid index pattern test to iterate through indices#70130
Merged
cuff-links merged 6 commits intoelastic:masterfrom Jul 2, 2020
Conversation
alisonelizabeth
approved these changes
Jun 27, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Overall LGTM. I left a few comments in the code, but nothing blocking. Did not test locally.
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
Author
|
@elasticmachine merge upstream |
…st_To_Iterate_Through_Indices
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jul 2, 2020
…es (elastic#70130) * Fixed assertion to check through all indices before making assertion. * Restored yarn.lock file. * Removed only from describe. * Fixed linting issue. * Fixed nits that were in the PR conversation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jul 2, 2020
…es (elastic#70130) * Fixed assertion to check through all indices before making assertion. * Restored yarn.lock file. * Removed only from describe. * Fixed linting issue. * Fixed nits that were in the PR conversation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 2, 2020
* master: (46 commits) [Visualize] Add missing advanced settings and custom label for pipeline aggs (elastic#69688) Use dynamic: false for config saved object mappings (elastic#70436) [Ingest Pipelines] Error messages (elastic#70167) [APM] Show transaction rate per minute on Observability Overview page (elastic#70336) Filter out error when calculating a label (elastic#69934) [Visualizations] Each visType returns its supported triggers (elastic#70177) [Telemetry] Report data shippers (elastic#64935) Reduce SavedObjects mappings for Application Usage (elastic#70475) [Lens] fix dimension label performance issues (elastic#69978) Skip failing endgame tests (elastic#70548) [SIEM] Reenabling Cypress tests (elastic#70397) [SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (elastic#67707) [Security] Adds field mapping support to rule creation (elastic#70288) SECURITY-ENDPOINT: add fields for events to metadata document (elastic#70491) Fixed assertion in hybrid index pattern test to iterate through indices (elastic#70130) [SIEM][Exceptions] - Exception builder component (elastic#67013) [Ingest Manager] Rename data sources to package configs (elastic#70259) skip suites blocking es snapshot promomotion (elastic#70532) [Metrics UI] Fix asynchronicity and error handling in Snapshot API (elastic#70503) fix export response (elastic#70473) ...
cuff-links
pushed a commit
that referenced
this pull request
Jul 2, 2020
…es (#70130) (#70540) * Fixed assertion to check through all indices before making assertion. * Restored yarn.lock file. * Removed only from describe. * Fixed linting issue. * Fixed nits that were in the PR conversation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cuff-links
pushed a commit
that referenced
this pull request
Jul 2, 2020
…es (#70130) (#70541) * Fixed assertion to check through all indices before making assertion. * Restored yarn.lock file. * Removed only from describe. * Fixed linting issue. * Fixed nits that were in the PR conversation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #68858
Issue
When Cloud deployments are created, 3 index patterns are created for metrics, APM, etc. When this test ran, it creates a new index pattern that is a hybrid between a rollup index and a standard index pattern. When the assertion is made to ensure that the name and rollup tag are included in the table, the test logic assumed the list was empty and did not account for any possible index patterns that may have already existed.
How To Test
Create an index pattern in the cluster that you are testing against so that it exists prior to the hybrid test running and then run the test. The test now iterates through all index patterns and finds the correct one.
Tested against Cloud Master and 7.8 along with master locally.