[Logs UI] ML log integration splash screen by afgomez · Pull Request #69288 · elastic/kibana

afgomez · 2020-06-16T15:35:01Z

Summary

Add a splash screen to ML integration pages, allowing users to start a trial period or upgrade to the right license if the features are not available for them.

Closes #64921

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser

elasticmachine · 2020-06-16T15:39:10Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

afgomez · 2020-06-17T13:29:01Z

@elasticmachine merge upstream

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx

Kerry350

Functionality LGTM 👍

However, I did leave a few comments around wording, small nits, and some stylistic suggestions.

Edit: Added a couple of extra comments. I think the runtime type checking and handling of the error state is quite important.

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx

x-pack/plugins/infra/public/hooks/use_trial_state.tsx

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

afgomez · 2020-06-24T10:01:05Z

@elasticmachine merge upstream

kibanamachine · 2020-06-24T14:36:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f97a09b

Build metrics

✅ unchanged

History

💚 Build #55873 succeeded 657ebf8
💚 Build #55846 succeeded 4e1a445
💚 Build #55034 succeeded 9546350
💚 Build #54992 succeeded b8e5860
💔 Build #54955 failed bd8c7e9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Kerry350

Thanks for the changes 👌

* master: (45 commits) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) [ML] DF Analytics: Creation wizard part 3 (elastic#69456) Update Resolver generator script documentation (elastic#69912) [ML] Changes View results button text on new job page (elastic#69809) Add master branch to backport config (elastic#69893) [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761) unskips 'Events columns' test (elastic#69684) [ML] Changes the ML overview empty analytics panel text (elastic#69801) [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812) add the `exactRoute` property to app registration (elastic#69772) Bump backport to 5.4.6 (elastic#69880) [Logs UI] ML log integration splash screen (elastic#69288) Clean up TSVB type client code to conform to the schema (elastic#68519) ...

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Alejandro Fernández Gómez added 6 commits June 12, 2020 13:49

Make all tabs always visible

f720fb5

Layout for splash screen

1a5a99b

Add content for start trial

1da2dcb

Adapt content for trial or upgrade cases

3c0e442

Add destionations to the CTAs

b2af231

Detect if is possible to enable trial

6add297

afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 16, 2020

Add splash screen to log entry categorization

a350453

afgomez marked this pull request as ready for review June 16, 2020 15:39

afgomez requested a review from a team as a code owner June 16, 2020 15:39

afgomez changed the title ~~64921 ml logs splash screen~~ [Logs UI] ML log integration splash screen Jun 17, 2020

afgomez added release_note:roadmap release_note:enhancement and removed release_note:roadmap labels Jun 17, 2020

elasticmachine and others added 2 commits June 17, 2020 07:29

Merge branch 'master' into 64921-ml-logs-splash-screen

93d10fe

Tweak mobile layout

bd8c7e9

katrin-freihofner reviewed Jun 18, 2020

View reviewed changes

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved

...k/plugins/infra/public/components/logging/log_analysis_setup/subscription_splash_content.tsx Outdated Show resolved Hide resolved

Alejandro Fernández Gómez added 4 commits June 18, 2020 14:42

Use only valid paths

62a8593

Add loader to splash screen

6bc5bc3

Prevent CTA from taking the full width

b8e5860

Correct capitalization of subscription

9546350

Kerry350 self-requested a review June 23, 2020 08:33

Kerry350 reviewed Jun 23, 2020

View reviewed changes

x-pack/plugins/infra/public/hooks/use_trial_state.tsx Outdated Show resolved Hide resolved

Kerry350 reviewed Jun 23, 2020

View reviewed changes

x-pack/plugins/infra/public/hooks/use_trial_state.tsx Outdated Show resolved Hide resolved

bmorelli25 reviewed Jun 23, 2020

View reviewed changes

Update copy

ebe00ef

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>

Merge branch 'master' into 64921-ml-logs-splash-screen

4e1a445

sgrodzicki added this to the Logs UI 7.9 milestone Jun 24, 2020

Alejandro Fernández Gómez added 4 commits June 24, 2020 13:49

Use useTrackedPromise

88ce6c9

Align file and export names

a8c3927

Parse API response

657ebf8

Add feedback for the error case

f97a09b

Kerry350 approved these changes Jun 25, 2020

View reviewed changes

afgomez merged commit f6c9ca2 into elastic:master Jun 25, 2020

afgomez deleted the 64921-ml-logs-splash-screen branch June 25, 2020 08:18

afgomez mentioned this pull request Jun 25, 2020

[7.x] [Logs UI] ML log integration splash screen (#69288) #69916

Merged

afgomez pushed a commit that referenced this pull request Jun 25, 2020

[7.x] [Logs UI] ML log integration splash screen (#69288) (#69916)

4951124

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

This was referenced Jul 3, 2020

[APM] Update license prompts to new and improved design #70691

Closed

[Logs] Anomaly detection license prompt copy around trial period is incorrect #70706

Closed

Conversation

afgomez commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jun 16, 2020

Uh oh!

afgomez commented Jun 17, 2020

Uh oh!

Uh oh!

Uh oh!

Kerry350 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

afgomez commented Jun 24, 2020

Uh oh!

kibanamachine commented Jun 24, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

Kerry350 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

afgomez commented Jun 16, 2020 •

edited

Loading

Kerry350 left a comment •

edited

Loading