[SIEM] Fixes flyout flaky test#68683
Merged
MadameSheema merged 2 commits intoelastic:masterfrom Jun 10, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
x-pack/plugins/security_solution/cypress/integration/timeline_flyout_button.spec.ts
Outdated
Show resolved
Hide resolved
…flyout_button.spec.ts Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
andrew-goldstein
approved these changes
Jun 9, 2020
Contributor
There was a problem hiding this comment.
Thanks @MadameSheema!
The node x-pack/plugins/security_solution/scripts/loop_cypress_tests.js script isn't working for me locally, which is likely an environment issue with my laptop, so I ran the test manually via yarn cypress:open.
LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Jun 10, 2020
* fixes flaky test * Update x-pack/plugins/security_solution/cypress/integration/timeline_flyout_button.spec.ts Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: [Ingest Manager] Document fleet configuration flags (elastic#66736) [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (elastic#68678) [SIEM][Detections Engine] - Exceptions viewer cleanup (elastic#68651) [SIEM] Fixes flyout flaky test (elastic#68683) [SIEM] Cypress renaming (elastic#68659)
MadameSheema
added a commit
that referenced
this pull request
Jun 10, 2020
* fixes flaky test * Update x-pack/plugins/security_solution/cypress/integration/timeline_flyout_button.spec.ts Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are fixing the flyout flaky test.
The test has been executed 30 times in local emulating Jenkins environment and passes all the time.