💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 6631d8b

History

• 💔 Build #51537 failed c502959

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Note: for testing this, you will need to set these inside your kibana.yml config:

xpack.lists.enabled: true
xpack.ingestManager.enabled: true

This enables the SIEM plugin which will register the ServiceNow and Jira action types.

I'm curious about this mechanism. Guessing we see the SN and Jira action types from the actions plugin API, but then these actionParamsFields are only set when the action type is registered in a ui plugin, hence filtering them out.

From 10K feet, it seems like it's making use of some implementation detail, which seems not great, vs some more explicit / declarative approach. But fine for now. Maybe with the RBAC stuff coming it may make more sense to handle this kind of thing that way (but I'm thinking RBAC is for alerts and not really actions).

I'm curious about this mechanism. Guessing we see the SN and Jira action types from the actions plugin API, but then these actionParamsFields are only set when the action type is registered in a ui plugin, hence filtering them out.

The action types that aren't registered in the UI get filtered out on the line above the filter I added (https://github.com/elastic/kibana/blob/master/x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx#L549).

The ServiceNow and Jira have UI components registered (https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/common/lib/connectors/servicenow/index.tsx#L41-L46) but don't define an actionParamsFields value. Without this change, we render an empty form. Though, I'm surprised we support this 🤔 https://github.com/elastic/kibana/blob/master/x-pack/plugins/triggers_actions_ui/public/types.ts#L61-L63 in TypeScript.

A follow up issue #68311 has been opened in regards to what is discussed above.