[SIEM] Fix draft timeline can be attached to a case#67844
Merged
patrykkopycinski merged 3 commits intoelastic:masterfrom Jun 2, 2020
Merged
[SIEM] Fix draft timeline can be attached to a case#67844patrykkopycinski merged 3 commits intoelastic:masterfrom
patrykkopycinski merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
stephmilovic
reviewed
Jun 1, 2020
x-pack/plugins/siem/public/timelines/components/timeline/properties/index.test.tsx
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
angorayc
approved these changes
Jun 2, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jun 2, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jun 2, 2020
# Conflicts: # x-pack/plugins/siem/public/timelines/components/flyout/header/index.tsx # x-pack/plugins/siem/public/timelines/components/timeline/properties/helpers.tsx # x-pack/plugins/siem/public/timelines/components/timeline/properties/index.test.tsx # x-pack/plugins/siem/public/timelines/components/timeline/properties/index.tsx # x-pack/plugins/siem/public/timelines/components/timeline/properties/properties_right.tsx
patrykkopycinski
added a commit
that referenced
this pull request
Jun 2, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Jun 2, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now you can attach a draft timeline to a case. This could be confusing for the user since the timeline draft is going to be overridden if a title is not entered when creating a new one.
For the user, this could end up having attached into a case a timeline that is not expecting.
The solution is to disable the "Attach" button when the Timeline has a
draftstatus.Checklist
Delete any items that are not applicable to this PR.
For maintainers