Skip to content

[settings/object] fix export all button, searchType: scan is gone#6774

Merged
epixa merged 1 commit intoelastic:masterfrom
spalger:fix/exportAll
Apr 4, 2016
Merged

[settings/object] fix export all button, searchType: scan is gone#6774
epixa merged 1 commit intoelastic:masterfrom
spalger:fix/exportAll

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Apr 4, 2016

Fixes #6414

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Apr 4, 2016

What did searchType even do?

@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Apr 4, 2016

searchType: 'scan' used to be required for walking through a sorted set of documents in an efficient way but it was deprecated in 2.1 and is no longer needed (or supported). More info: https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_50_search_changes.html#_literal_search_type_scan_literal_removed

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Apr 4, 2016

Does it make sense to also send sort:_doc then? That looks to be the recommendation from that BC doc page.

@bevacqua
Copy link
Copy Markdown
Contributor

bevacqua commented Apr 4, 2016

Ah. I thought it was still there, according to `elasticsearch-js: https://github.com/elastic/elasticsearch-js/blob/master/src/lib/apis/2_3.js#L5426-L5435

I suspected some mutability bug or something like that

Where is it gone from exactly?

@bevacqua
Copy link
Copy Markdown
Contributor

bevacqua commented Apr 4, 2016

LGTM

@bevacqua
Copy link
Copy Markdown
Contributor

bevacqua commented Apr 4, 2016

One comment I have here though, is that we should really handle the error.

Maybe:

if (error) {
  console.error(error);
  reject(error);
  return;
}

@w33ble
Copy link
Copy Markdown
Contributor

w33ble commented Apr 4, 2016

This LGTM, based on the docs and the fact that I successfully exported 170 saved objects. :shipit:

@epixa epixa merged commit a7ff5b0 into elastic:master Apr 4, 2016
bevacqua added a commit to bevacqua/kibana that referenced this pull request Apr 4, 2016
@bevacqua
[settings/object] Introduce visibility into export all button when ES…
65467f0 
… query fails. Related to elastic#6774.
@bevacqua bevacqua mentioned this pull request Apr 4, 2016
Closed
@spalger spalger mentioned this pull request Apr 5, 2016
Closed
@bevacqua bevacqua mentioned this pull request Apr 19, 2016
Merged
@spalger spalger deleted the fix/exportAll branch October 18, 2019 17:37
cee-chen added a commit that referenced this pull request May 31, 2023
@1Copenut @stratoula
@kibanamachine @cee-chen
Upgrade EUI to v81.0.0 (#158330)
aa1d266 
## Summary

`@elastic/eui@80.0.0` ⏩ `@elastic/eui@81.0.0`

---

## [`81.0.0`](https://github.com/elastic/eui/tree/v81.0.0)

- Added ability to set `options.checked` to "mixed" in `EuiSelectable`
([#6774](elastic/eui#6774))

**Bug fixes**

- Portalled components (e.g. `EuiPopover`, `EuiModal`, `EuiFlyout`) will
correctly inherit text color from its nearest `EuiThemeProvider` parent.
`<EuiText color="default">` is no longer needed.
([#6775](elastic/eui#6775))

**Breaking changes**

- `EuiSelectable` no longer renders a `data-test-selected` attribute on
its list items. Use the `aria-checked` property instead
([#6774](elastic/eui#6774))
- Nested `EuiThemeProvider`s now render a wrapping `<span>` element in
order to correctly set the inherited text `color` of all descendants.
`<EuiText color="default">` is no longer needed.
([#6775](elastic/eui#6775))

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Constance Chen <constance.chen@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@epixa epixa

Labels

review v5.0.0-alpha1 v5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spalger @epixa @bevacqua @w33ble