[internal] Remove all variable redeclarations#6736
Merged
spalger merged 1 commit intoelastic:masterfrom Apr 1, 2016
Merged
Conversation
Redeclaring variables causes ambiguity and serves no purpose. It actually causes a runtime error when you do it with `let`, and we can enforce not doing it via a linter rule.
Contributor
Author
|
jenkins, test it |
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Remove all variable redeclarations Redeclaring variables causes ambiguity and serves no purpose. It actually causes a runtime error when you do it with `let`, and we can enforce not doing it via a linter rule. * Original sha: de20762 * Authored by Court Ewing <court@epixa.com> on 2016-04-01T18:21:55Z
This was referenced Apr 1, 2016
spalger
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Remove all variable redeclarations Redeclaring variables causes ambiguity and serves no purpose. It actually causes a runtime error when you do it with `let`, and we can enforce not doing it via a linter rule. * Original sha: de20762 * Authored by Court Ewing <court@epixa.com> on 2016-04-01T18:21:55Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 1, 2016
--------- **Commit 1:** [internal] Remove all variable redeclarations Redeclaring variables causes ambiguity and serves no purpose. It actually causes a runtime error when you do it with `let`, and we can enforce not doing it via a linter rule. * Original sha: de20762 * Authored by Court Ewing <court@epixa.com> on 2016-04-01T18:21:55Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redeclaring variables causes ambiguity and serves no purpose. It
actually causes a runtime error when you do it with
let, and we canenforce not doing it via a linter rule.
All of these instances were actually caught by adding the
no-redeclarelinter rule.