[kbn/optimizer] remove disconnect listener#67161
Merged
spalger merged 1 commit intoelastic:masterfrom May 21, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jbudz
approved these changes
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
pushed a commit
that referenced
this pull request
May 21, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 22, 2020
…) (elastic#67185)" This reverts commit a1c7cf1.
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 22, 2020
…) (elastic#67184)" This reverts commit d8ee965.
spalger
added a commit
that referenced
this pull request
May 23, 2020
* Revert "[7.7] [kbn/optimizer] remove disconnect listener (#67161) (#67185)" This reverts commit a1c7cf1. * Revert "[7.7] [kbn/optimizer] poll parent process to avoid zombie processes (#67059) (#67119)" This reverts commit e6a5a9d. Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to the
@kbn/optimizerin #67059 have lead to workers not exiting somewhat randomly. We have 18 builds that have failed since this was merged 19 hours ago.I'm suspecting the "disconnect" listener, which I removed previously for the same reason and added the check which is failing now, but I'm quite surprised to hear that it's flaky. I could imagine there's a race of some sort related to how the child processes receives the disconnected event.