Skip to content

[chore] Cleanup settings code style as reported by #6588.#6709

Merged
bevacqua merged 1 commit intoelastic:masterfrom
bevacqua:chore/settings-codestyle
Mar 31, 2016
Merged

[chore] Cleanup settings code style as reported by #6588.#6709
bevacqua merged 1 commit intoelastic:masterfrom
bevacqua:chore/settings-codestyle

Conversation

@bevacqua
Copy link
Copy Markdown
Contributor

@bevacqua bevacqua commented Mar 30, 2016

  • Removes an inconsecuential assignment
  • Replaces void 0 for a more clear undefined reference
  • Removes unnecessary parenthesis

@bevacqua bevacqua force-pushed the chore/settings-codestyle branch from 084b95d to 7b43d52 Compare March 30, 2016 20:11
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Mar 31, 2016

LGTM

@epixa epixa assigned bevacqua and unassigned epixa Mar 31, 2016
@bevacqua bevacqua merged commit 26cedc7 into elastic:master Mar 31, 2016
@bevacqua bevacqua deleted the chore/settings-codestyle branch March 31, 2016 17:40
@bevacqua bevacqua removed their assignment Mar 31, 2016
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Mar 31, 2016

@bevacqua Can you try to backport this to 4.x and 4.5? If it backports cleanly, great. If it doesn't, don't worry about it.

elastic-jasper added a commit that referenced this pull request Mar 31, 2016
@elastic-jasper
Backport PR #6709
f456be9 
---------

**Commit 1:**
[chore] Cleanup settings code style as reported. Fixes #6588.

* Original sha: 7b43d52
* Authored by Nicolas Bevacqua <nicolasbevacqua@gmail.com> on 2016-03-30T20:11:35Z
elastic-jasper added a commit that referenced this pull request Mar 31, 2016
@elastic-jasper
Backport PR #6709
a13ab16 
---------

**Commit 1:**
[chore] Cleanup settings code style as reported. Fixes #6588.

* Original sha: 7b43d52
* Authored by Nicolas Bevacqua <nicolasbevacqua@gmail.com> on 2016-03-30T20:11:35Z
This was referenced Mar 31, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

review v5.0.0-alpha1 v5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bevacqua @epixa