Timelion graph is not refreshing content after searching or filtering#67023
Timelion graph is not refreshing content after searching or filtering#67023DianaDerevyankina merged 4 commits intoelastic:masterfrom
Conversation
alexwizp
left a comment
There was a problem hiding this comment.
LGTM! Thank you. Tested locally
nit: I don't like the idea of using lodash here, because it causes such problems. It probably makes sense to refactor. But this is optional ...
|
@dziyanadzeraviankina I didn't test yet, but did you do some digging in how this bug was introduced? This particular line was last changed in 2017 which makes me anxious. It's probably a migration artifact but I would like to know more about the circumstances to make sure there are no other bugs like this hidden in there. |
|
@flash1293 After the migration hapi request was replaced with KibanaRequest |
|
Thanks @dziyanadzeraviankina , makes sense. It looks like this is the only place a property was accessed like this, so this looks good. I noticed there is the Could you remove that one as well? |
|
@flash1293 Sure, removed TimelionRequestQuery |
flash1293
left a comment
There was a problem hiding this comment.
Tested in Firefox and works as expected, LGTM 👍
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements adds the custom element to the workpad when promptedStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
…elastic#67023) * Timelion graph is not refreshing content after searching or filtering in Kibana Closes elastic#66560 * Change test beforeEach configuration to match request body * Remove unused TimelionRequestQuery
…elastic#67023) * Timelion graph is not refreshing content after searching or filtering in Kibana Closes elastic#66560 * Change test beforeEach configuration to match request body * Remove unused TimelionRequestQuery
…elastic#67023) * Timelion graph is not refreshing content after searching or filtering in Kibana Closes elastic#66560 * Change test beforeEach configuration to match request body * Remove unused TimelionRequestQuery
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (49 commits) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051) Remove unused license check result from LP Security plugin (elastic#66966) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/home.helpers.ts
* master: [apm] Annotation API documentation (elastic#65963) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) [Logs UI] Restore call to `UsageCollector.countLogs` (elastic#67051) Remove unused license check result from LP Security plugin (elastic#66966)
* master: (21 commits) [Alerting] Hides the `alert` SavedObjects type (elastic#66719) skip flaky suite (elastic#66869) fix visual baseline tests [kbn/optimizer] require fsevents on macos (elastic#67147) [APM] Fix obscured service map connections (elastic#67129) [apm] Annotation API documentation (elastic#65963) [Uptime] Improve responsiveness details page (elastic#67034) skip flaky suite (elastic#66669) Revert "Integration of a static filesystem for the node_modules (elastic#47998)" (elastic#67124) Support api_integration/kibana/stats against remote hosts (elastic#53000) chore(NA): add module name mapper for src plugins on x-pack (elastic#67103) Change the error message on TSVB in order to be more user friendly (elastic#67090) [kbn/optimizer] poll parent process to avoid zombie processes (elastic#67059) [Visualize] Lazy load default editor, fix duplicated styles (elastic#66732) Bump styled-component dependencies (elastic#66611) Bump react-markdown dependencies (elastic#66615) Fix Core docs links (elastic#66977) Timelion graph is not refreshing content after searching or filtering (elastic#67023) Remove `--xpack.endpoint.enabled=true` from README.md file (elastic#67053) Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432) ...
Closes #66560
Summary
Renamed path to filter in
build_request.tsto add it in query requestChecklist
Delete any items that are not applicable to this PR.
For maintainers