[internal] Reject CI builds if any .rej files exist#6692
Merged
epixa merged 1 commit intoelastic:masterfrom Mar 29, 2016
Merged
[internal] Reject CI builds if any .rej files exist#6692epixa merged 1 commit intoelastic:masterfrom
epixa merged 1 commit intoelastic:masterfrom
Conversation
.rej are the byproduct of failed patches via git-apply or artifacts of the backporting process through jasper. Any build that has them should be rejected early.
Contributor
Author
|
The easiest way to test this is probably to just create some random .rej files and then make sure the task is rejected with them: Then confirm that the task does not fail with .rej files in node_modules: |
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Reject CI builds if any .rej files exist .rej are the byproduct of failed patches via git-apply or artifacts of the backporting process through jasper. Any build that has them should be rejected early. * Original sha: 55e429c * Authored by Court Ewing <court@epixa.com> on 2016-03-29T17:24:24Z
elastic-jasper
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Reject CI builds if any .rej files exist .rej are the byproduct of failed patches via git-apply or artifacts of the backporting process through jasper. Any build that has them should be rejected early. * Original sha: 55e429c * Authored by Court Ewing <court@epixa.com> on 2016-03-29T17:24:24Z
This was referenced Mar 29, 2016
epixa
added a commit
that referenced
this pull request
Mar 29, 2016
--------- **Commit 1:** [internal] Reject CI builds if any .rej files exist .rej are the byproduct of failed patches via git-apply or artifacts of the backporting process through jasper. Any build that has them should be rejected early. * Original sha: 55e429c * Authored by Court Ewing <court@epixa.com> on 2016-03-29T17:24:24Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.rej are the byproduct of failed patches via git-apply or artifacts of
the backporting process through jasper. Any build that has them should
be rejected early.