Skip to content

[bootstrap/styles] add early support for v8 themes#66673

Merged
spalger merged 11 commits intoelastic:masterfrom
spalger:switch-between-v8-themes
May 21, 2020
Merged

[bootstrap/styles] add early support for v8 themes#66673
spalger merged 11 commits intoelastic:masterfrom
spalger:switch-between-v8-themes

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented May 14, 2020 •
edited
Loading

Fixes #61123

Summary

Implements initial support for the version 8 themes the EUI team is working on. To switch between themes there is a theme:version advanced setting which currently has two possible values v7 and v8. Changing this value and reloading the page will load the v7 or v8 css styles from @kbn/ui-shared-deps and the v7 or v8 theme files will be exported from @elastic/eui/dist/eui_theme_light.json, @elastic/eui/dist/eui_theme_dark.json, as well as a new module @kbn/ui-shared-deps/eui_theme. This new module exports euiThemeDark and euiThemeLight which represent the two previously mentioned sets of theme vars, as well as euiTheme which is automatically mapped to the right theme based on the current value of the theme:* settings.

2020-05-14 16 10 05

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ryankeairns ryankeairns requested review from cchaos and snide May 15, 2020 14:20
@snide
Copy link
Copy Markdown
Contributor

snide commented May 15, 2020

I did a quick run through this last night, and it worked as I'd expect. I don't think all the JSON import conversions needs to be done in this PR, but the method/example you set up makes sense to me and is clean.

Thanks for jumping on this so quickly, it's really gonna help us as we build out the new theme.

@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented May 15, 2020

@elasticmachine merge upstream

@snide
Copy link
Copy Markdown
Contributor

snide commented May 19, 2020

@spalger Is this reviewable?

@spalger spalger added Team:Operations Kibana-Operations Team v7.9.0 v8.0.0 labels May 19, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 19, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger added release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels May 19, 2020
@spalger spalger marked this pull request as ready for review May 19, 2020 14:15
@spalger spalger requested a review from a team as a code owner May 19, 2020 14:15
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented May 20, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 20, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger requested a review from a team May 20, 2020 21:09
tylersmalley
tylersmalley reviewed May 20, 2020
View reviewed changes
tylersmalley
tylersmalley approved these changes May 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Ops

snide
snide approved these changes May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in browser to make sure it works how I'd suspect. I also did a brief run through of the code to make sure it's flexible enough for designs needs. Likely there will be some downstream changes in the apps that will need to follow, but nothing with the current defaults will have any ripples from this change.

Thanks for adding this one so quickly. 🎉

@spalger spalger merged commit 93c3a63 into elastic:master May 21, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request May 21, 2020
@spalger
[bootstrap/styles] add early support for v8 themes (elastic#66673)
6e1c569
@spalger spalger mentioned this pull request May 21, 2020
Merged
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request May 21, 2020
@tsullivan
[bootstrap/styles] add early support for v8 themes (elastic#66673)
3dd7fb4
spalger pushed a commit that referenced this pull request May 22, 2020
@elasticmachine
[bootstrap/styles] add early support for v8 themes (#66673) (#67215)
0eddeee 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger spalger mentioned this pull request Jun 29, 2020
Merged
@spalger spalger deleted the switch-between-v8-themes branch August 18, 2020 17:54
@spalger spalger mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@cchaos cchaos Awaiting requested review from cchaos

+2 more reviewers

@snide snide snide approved these changes

@joshdover joshdover joshdover approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Advanced settings toggle for new EUI theme

7 participants

@spalger @snide @elasticmachine @kibanamachine @tylersmalley @cchaos @joshdover