[Component templates] Server side#66596
Merged
alisonelizabeth merged 9 commits intomasterfrom Jun 1, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
sebelga
approved these changes
May 29, 2020
Contributor
sebelga
left a comment
There was a problem hiding this comment.
LGTM! Thanks for putting this PR together @alisonelizabeth !
cjcenizal
approved these changes
May 30, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM! Had one suggestion, not a blocker.
| import { registerUpdateRoute } from './update'; | ||
| import { registerDeleteRoute } from './delete'; | ||
|
|
||
| export function registerComponentTemplateRoutes(dependencies: RouteDependencies) { |
Contributor
There was a problem hiding this comment.
WDYT of moving all of this code into index.ts? This way there's roughly a 1-to-1 relationship with the register_<thing>.ts files and the routes that get registered. I did this in ILM if you want to see how it would look.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
Jun 1, 2020
alisonelizabeth
added a commit
that referenced
this pull request
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #64771.
This PR delivers the server side code needed for the Component Templates UI. It has already been reviewed via #66684.
Note: I am skipping a release note. I don't think it is necessary until we add the UI.