Fix/move append nav controls by panda01 · Pull Request #6645 · elastic/kibana

panda01 · 2016-03-24T18:55:49Z

Fixes spacing issue with timepicker showing a bottom border
Moves append nav controls to the sidebar on the left
Removes the timepicker and loading indicator from the kbn append nav controls
Makes some changes to chrome for shield

Breaking up of #6502.

cleanup

…works right

…picker directives

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

rashidkpc · 2016-03-24T19:02:29Z

src/ui/public/chrome/directives/index.js

 import './app_switcher';
 import kbnChromeProv from './kbn_chrome';
 import kbnChromeNavControlsProv from './append_nav_controls';
+import courierLoadingIndicator from './kbn_loading_indicator';


this doesn't need to be named does it?

Move kbn-loading-indicator to element

rashidkpc · 2016-03-24T20:37:38Z

rename toggle.js to kbn_global_timepicker.js?

rashidkpc · 2016-03-24T20:37:48Z

This breaks auto-refresh

…timepicker file

…Controls

panda01 · 2016-03-25T00:15:56Z

@rashidkpc I addressed your concerns.

panda01 · 2016-03-28T12:33:15Z

jenkins, test it

rashidkpc · 2016-03-28T22:08:04Z

The parts of this I know well LGTM. @w33ble can you check if this jives with your button injection jazz?

w33ble · 2016-03-29T17:45:27Z

src/ui/public/chrome/__tests__/kbn_loading_indicator.js

+    expect($el.find('.spinner')).to.have.length(1);
+  });
+  // Doesn't work...
+  xit('applies the ng-hide class when there are no connections', function () {


xit? Is this some kind of alias for it.skip?

Whoops this slipped past me i'll remove this.

w33ble · 2016-03-29T17:54:24Z

Conflicts with #6684, but the fixes are super easy, and everything works together once you make them.

@panda01 can you comment on the xit thing? Other than that, this LGTM.

panda01 · 2016-03-29T18:16:46Z

@w33ble ok cool, what i'm going to do is remove this, and merge in your branch first, and then fix the conflicts. afterwards i'll pass it back.

…Controls

## Summary eui@76.0.2 ⏩ eui@76.3.0 ## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0) - Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array of query selector strings ([#6646](elastic/eui#6646)) **Bug fixes** - Fixed `EuiFlyout` to preserve body scrollbar width on open ([#6645](elastic/eui#6645)) - Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([#6645](elastic/eui#6645)) - Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([#6645](elastic/eui#6645)) ## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0) - Added new `renderCustomGridBody` escape hatch rendering prop to `EuiDataGrid` ([#6624](elastic/eui#6624)) **Bug fixes** - Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s ([#6637](elastic/eui#6637)) - Added a legacy `alert` alias for the `warning` `EuiIcon` type ([#6640](elastic/eui#6640)) - Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects ([#6643](elastic/eui#6643)) ## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0) - Added more detailed screen reader instructions to `EuiSelectable`, `EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and `EuiDualRange`. ([#6589](elastic/eui#6589)) - Added new `placeholder` prop to `EuiSuperSelect` ([#6630](elastic/eui#6630)) - Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s `renderCellPopover` prop ([#6632](elastic/eui#6632)) **Bug fixes** - Fixed an ARIA attribute in `EuiSelectableList` ([#6589](elastic/eui#6589)) - Fixed `EuiSelectable` to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. ([#6631](elastic/eui#6631)) --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>

## Summary eui@76.0.2 ⏩ eui@76.3.0 ## [`76.3.0`](https://github.com/elastic/eui/tree/v76.3.0) - Updated `EuiSkipLink`'s `fallbackDestination` prop to support an array of query selector strings ([elastic#6646](elastic/eui#6646)) **Bug fixes** - Fixed `EuiFlyout` to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiImage`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) - Fixed `EuiCodeBlock`'s full screen mode to not scroll jump & to preserve body scrollbar width on open ([elastic#6645](elastic/eui#6645)) ## [`76.2.0`](https://github.com/elastic/eui/tree/v76.2.0) - Added new `renderCustomGridBody` escape hatch rendering prop to `EuiDataGrid` ([elastic#6624](elastic/eui#6624)) **Bug fixes** - Fixed visual listbox focus ring bug on non-searchable `EuiSelectable`s ([elastic#6637](elastic/eui#6637)) - Added a legacy `alert` alias for the `warning` `EuiIcon` type ([elastic#6640](elastic/eui#6640)) - Fixed a type definition incorrectly coming from a dev dependency, which was causing issues for some consuming projects ([elastic#6643](elastic/eui#6643)) ## [`76.1.0`](https://github.com/elastic/eui/tree/v76.1.0) - Added more detailed screen reader instructions to `EuiSelectable`, `EuiSuggest`, `EuiSelectableTemplateSitewide`, `EuiRange`, and `EuiDualRange`. ([elastic#6589](elastic/eui#6589)) - Added new `placeholder` prop to `EuiSuperSelect` ([elastic#6630](elastic/eui#6630)) - Added new `setCellPopoverProps` parameter callback to `EuiDataGrid`'s `renderCellPopover` prop ([elastic#6632](elastic/eui#6632)) **Bug fixes** - Fixed an ARIA attribute in `EuiSelectableList` ([elastic#6589](elastic/eui#6589)) - Fixed `EuiSelectable` to no longer show active selection state or respond to the Up/Down arrow keys when focus is inside the selectable container, but not on the searchbox or listbox. ([elastic#6631](elastic/eui#6631)) --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>

panda01 and others added 6 commits March 24, 2016 14:42

[Chrome] Append nav controls changes

f7112d4

[kbnLoading] Made the directive so we dont have to repeat, with some

10c5223

cleanup

[Chrome] Made some stlye changes and html to ensure shield looks and …

ffe9ed4

…works right

[Tests] Wrote some simple tests around the loading indicator and time…

2aa7665

…picker directives

Resolves ngMock dependency

536f211

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

[Shield] Some integration for shield, and code cleanup

ab1f953

panda01 added the v5.0.0-alpha1 label Mar 24, 2016

panda01 assigned lukasolson Mar 24, 2016

rashidkpc reviewed Mar 24, 2016
View reviewed changes

panda01 and others added 6 commits March 24, 2016 15:31

[Tests] Fixing tests

db2074e

[Logo] Putting back the old logo

2202f7f

Make the loader an element instead

e9dbcdc

Tests updates

e60aca3

Merge pull request #1 from rashidkpc/pr/6645

6b47ced

Move kbn-loading-indicator to element

[Chrome] some cleanup

cabec73

rashidkpc assigned panda01 and unassigned lukasolson Mar 24, 2016

epixa added the v5.0.0 label Mar 24, 2016

[Timepicker] fixing the auto refresh so it works properly, moved the …

1e395bf

…timepicker file

panda01 force-pushed the fix/moveAppendNavControls branch from 4dba9d5 to 1e395bf Compare March 24, 2016 22:57

Merge remote-tracking branch 'upstream/master' into fix/moveAppendNav…

1634340

…Controls

panda01 added the review label Mar 28, 2016

panda01 removed their assignment Mar 28, 2016

panda01 assigned rashidkpc Mar 28, 2016

rashidkpc assigned w33ble and unassigned rashidkpc Mar 28, 2016

w33ble reviewed Mar 29, 2016
View reviewed changes

w33ble assigned panda01 and unassigned w33ble Mar 29, 2016

panda01 added 2 commits March 29, 2016 14:22

Merge remote-tracking branch 'upstream/master' into fix/moveAppendNav…

e948df3

…Controls

[Tests] removing old test

ebf4ae5

panda01 assigned w33ble and unassigned panda01 Mar 29, 2016

w33ble merged commit 9a80ee5 into elastic:master Mar 29, 2016

panda01 mentioned this pull request Mar 30, 2016

Timepicker and top navigation fixes #6657

Merged

epixa added v5.0.0-alpha1 and removed v5.0.0-alpha1 labels Mar 31, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/move append nav controls#6645

Fix/move append nav controls#6645
w33ble merged 16 commits intoelastic:masterfrom
panda01:fix/moveAppendNavControls

panda01 commented Mar 24, 2016

Uh oh!

rashidkpc Mar 24, 2016

Uh oh!

rashidkpc commented Mar 24, 2016

Uh oh!

rashidkpc commented Mar 24, 2016

Uh oh!

panda01 commented Mar 25, 2016

Uh oh!

panda01 commented Mar 28, 2016

Uh oh!

rashidkpc commented Mar 28, 2016

Uh oh!

w33ble Mar 29, 2016

Uh oh!

panda01 Mar 29, 2016

Uh oh!

w33ble commented Mar 29, 2016

Uh oh!

panda01 commented Mar 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

panda01 commented Mar 24, 2016

Uh oh!

rashidkpc Mar 24, 2016

Choose a reason for hiding this comment

Uh oh!

rashidkpc commented Mar 24, 2016

Uh oh!

rashidkpc commented Mar 24, 2016

Uh oh!

panda01 commented Mar 25, 2016

Uh oh!

panda01 commented Mar 28, 2016

Uh oh!

rashidkpc commented Mar 28, 2016

Uh oh!

w33ble Mar 29, 2016

Choose a reason for hiding this comment

Uh oh!

panda01 Mar 29, 2016

Choose a reason for hiding this comment

Uh oh!

w33ble commented Mar 29, 2016

Uh oh!

panda01 commented Mar 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants