[Visualize] Bar chart: Show missing values on chart setting#66375
Merged
sulemanof merged 7 commits intoelastic:masterfrom May 19, 2020
Merged
[Visualize] Bar chart: Show missing values on chart setting#66375sulemanof merged 7 commits intoelastic:masterfrom
sulemanof merged 7 commits intoelastic:masterfrom
Conversation
ppisljar
approved these changes
May 13, 2020
Contributor
ppisljar
left a comment
There was a problem hiding this comment.
code LGTM, could we add a test for this ?
Contributor
|
I think we should somehow add a functional test for that. Though this would need to check the chart, which will as soon as we switch to elastic-charts (and thus canvas rendering) not be as easy anymore. But we should at least check it for now, and maybe later need to convert it to screenshot tests. |
Contributor
|
@elasticmachine merge upstream |
flash1293
reviewed
May 19, 2020
Contributor
There was a problem hiding this comment.
Tested in Firefox and works as expected. I noticed one strange behavior, not sure whether introduced by this PR:
- Create a bar chart with two metrics - "show values" is available
- Change the first metric to line - "show values" is available (which makes sense as there is still a "bar" metric)
- Change the second metric to area - "show values" is available (doesn't make sense, as it's not applied anymore)
- Change the second metric to line as well - "show values" is not available any more
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Thanks @flash1293 for the good points you mentioned! Updated:
|
Contributor
|
@sulemanof In that case this LGTM |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
May 19, 2020
…66375) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
May 19, 2020
…66375) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx # test/functional/page_objects/visualize_chart_page.ts # test/functional/page_objects/visualize_editor_page.ts
sulemanof
added a commit
that referenced
this pull request
May 19, 2020
sulemanof
added a commit
that referenced
this pull request
May 19, 2020
sulemanof
added a commit
that referenced
this pull request
May 19, 2020
…67025) * Show missing switch button * Add functional tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx # test/functional/page_objects/visualize_chart_page.ts # test/functional/page_objects/visualize_editor_page.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 20, 2020
* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66365
Rely on
vis.type.nameinstead ofvis.type.type, since the last one is gone.Can't rely on
vis.params.type, since it is not changed when a chart type is changed via select inMetrics & axespanel:Checklist
Delete any items that are not applicable to this PR.
For maintainers