[SIEM] Cases] Capture timeline click and open timeline in case view#66327
Merged
stephmilovic merged 14 commits intoelastic:masterfrom May 18, 2020
Merged
[SIEM] Cases] Capture timeline click and open timeline in case view#66327stephmilovic merged 14 commits intoelastic:masterfrom
stephmilovic merged 14 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
stephmilovic
commented
May 12, 2020
| export interface QueryTimelineById<TCache> { | ||
| apolloClient: ApolloClient<TCache> | ApolloClient<{}> | undefined; | ||
| duplicate: boolean; | ||
| duplicate?: boolean; |
Contributor
Author
There was a problem hiding this comment.
this is defaulted to false, so not required
Contributor
Author
|
@elasticmachine merge upstream |
…/kibana into capture-case-timeline-click
MadameSheema
approved these changes
May 14, 2020
Contributor
MadameSheema
left a comment
There was a problem hiding this comment.
Lots of thanks for maintaining the Cypress tests 👏
Contributor
Author
|
@elasticmachine merge upstream |
…/kibana into capture-case-timeline-click
cnasikas
approved these changes
May 18, 2020
Member
cnasikas
left a comment
There was a problem hiding this comment.
LGTM! Reviewed the code and tested locally.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
May 18, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 19, 2020
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
stephmilovic
added a commit
that referenced
this pull request
May 19, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hijack any timeline link click in the case markdown area to open the timeline via redux in case. The link will still work as a hyperlink in external systems.
Checklist
Delete any items that are not applicable to this PR.