Add globalSearch x-pack plugin#66293
Merged
pgayvallet merged 55 commits intoelastic:masterfrom Jun 4, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
mshustov
reviewed
Jun 2, 2020
mshustov
reviewed
Jun 2, 2020
mshustov
reviewed
Jun 2, 2020
|
|
||
| import { of, throwError } from 'rxjs'; | ||
| import supertest from 'supertest'; | ||
| import { UnwrapPromise } from '@kbn/utility-types'; |
Contributor
There was a problem hiding this comment.
a side note: Finally we will get rid of this microsoft/TypeScript#27711
mshustov
reviewed
Jun 2, 2020
| const factory = getContextFactory(coreStart); | ||
| const context = factory(request); | ||
|
|
||
| expect(coreStart.savedObjects.getScopedClient).toHaveBeenCalledTimes(1); |
Contributor
There was a problem hiding this comment.
I don't know if it's worth adding such a detailed test. The only logic in the factory that uiSettings.client uses the same soClient instance. Which can be considered an implementation detail.
mshustov
reviewed
Jun 2, 2020
| export default { | ||
| rootDir: '../../', | ||
| roots: [ | ||
| '<rootDir>/plugins', |
Contributor
There was a problem hiding this comment.
is this file used? x-pack/scripts/jest uses another config file
Contributor
Author
There was a problem hiding this comment.
It is, but only by the integration test config. The jest command in xpack does not, and use the file you linked instead 🙈
kibana/x-pack/test_utils/jest/config.integration.js
Lines 8 to 11 in bf04235
mshustov
reviewed
Jun 2, 2020
Contributor
mshustov
left a comment
There was a problem hiding this comment.
LGTM. The last pending question is #66293 (comment)
joshdover
approved these changes
Jun 3, 2020
mshustov
reviewed
Jun 4, 2020
|
|
||
| ```ts | ||
| startDeps.globalSearch.find('some term').subscribe( | ||
| ({ results }) => { |
Contributor
There was a problem hiding this comment.
Optional: while this form is completely fine in the code when IDE gives you hints, it's not reader-friendly when used in the docs. What if we provide a verbose example:
startDeps.globalSearch.find('some term').subscribe({
next ({ results }) {
addNewResultsToList(results);
},
error(){},
complete() {
showAsyncSearchIndicator(false);
}
});
mshustov
reviewed
Jun 4, 2020
| }); | ||
| ``` | ||
|
|
||
| ## Known limitations |
Contributor
There was a problem hiding this comment.
You can link the RFC for more details provided
mshustov
reviewed
Jun 4, 2020
| ): string => { | ||
| if (typeof url === 'string') { | ||
| // relative path | ||
| if (url.indexOf('/') === 0) { |
Contributor
There was a problem hiding this comment.
optional: url.startsWith('/') is a bit clearer
mshustov
approved these changes
Jun 4, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 4, 2020
* add skeleton for global_search plugin * base implementation of the server-side service * add utils tests * add server-side mocks * move take_in_array to common folder * implements base of client-side plugin * add tests for server-side service * fix server plugin tests * implement `navigateToUrl` core API * extract processResults for the client-side * fetch server results from the client side * factorize process_results * fix plugin start params * move things around * move all server types to single file * fix types imports * add basic FTR tests * add client-side service tests * add tests for addNavigate * add getDefaultPreference & tests * use optional for RequestHandlerContext * add registerRoutes test * add base test for context * resolve TODO * common nits/doc * common nits/doc on public * update CODEOWNERS * add import for declare statement * add license check on the server-side * add license check on the client-side * eslint * address some review comments * use properly typed errors for obs * add integration tests for the find endpoint * fix unit tests * use licensing start contract * translate the error message * fix eslint rule for test_utils * fix test_utils imports * remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead. * use coreProvider plugin in FTR tests * nits * fix service start params * fix service start params, bis * I really need to fix this typecheck oom error * add README, update missing jsdoc * nits on doc # Conflicts: # .github/CODEOWNERS # rfcs/text/0011_global_search.md
pgayvallet
added a commit
that referenced
this pull request
Jun 4, 2020
* add skeleton for global_search plugin * base implementation of the server-side service * add utils tests * add server-side mocks * move take_in_array to common folder * implements base of client-side plugin * add tests for server-side service * fix server plugin tests * implement `navigateToUrl` core API * extract processResults for the client-side * fetch server results from the client side * factorize process_results * fix plugin start params * move things around * move all server types to single file * fix types imports * add basic FTR tests * add client-side service tests * add tests for addNavigate * add getDefaultPreference & tests * use optional for RequestHandlerContext * add registerRoutes test * add base test for context * resolve TODO * common nits/doc * common nits/doc on public * update CODEOWNERS * add import for declare statement * add license check on the server-side * add license check on the client-side * eslint * address some review comments * use properly typed errors for obs * add integration tests for the find endpoint * fix unit tests * use licensing start contract * translate the error message * fix eslint rule for test_utils * fix test_utils imports * remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead. * use coreProvider plugin in FTR tests * nits * fix service start params * fix service start params, bis * I really need to fix this typecheck oom error * add README, update missing jsdoc * nits on doc # Conflicts: # .github/CODEOWNERS # rfcs/text/0011_global_search.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First stage of #61657
Implementation of #64284
globalSearchx-pack pluginChecklist