[Ingest pipelines] Make description field optional#65961
Merged
alisonelizabeth merged 3 commits intoelastic:masterfrom May 11, 2020
Merged
Conversation
…nes/bugfix/description_field
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
approved these changes
May 11, 2020
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Changes make sense to me!
I did not test locally, happy with the Jest test added. One question, do we have an API integration test that sends through a request to the create endpoint without a description?
Contributor
Author
|
@jloleysens thanks for the review!
Thanks for pointing this out! Just added one. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced May 11, 2020
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
May 11, 2020
alisonelizabeth
added a commit
that referenced
this pull request
May 11, 2020
alisonelizabeth
added a commit
that referenced
this pull request
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the client validation in place for the description field when creating a pipeline, as the ES API does not require it.