Skip to content

[7.8] Fix anomalies display on focused APM service map (#65882)#65917

Merged
smith merged 1 commit intoelastic:7.8from
smith:backport/7.8/pr-65882
May 8, 2020
Merged

[7.8] Fix anomalies display on focused APM service map (#65882)#65917
smith merged 1 commit intoelastic:7.8from
smith:backport/7.8/pr-65882

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented May 8, 2020

Backports the following commits to 7.8:

The map anomlies rings display was working on the global map and on the focused service of a focused map, but not on the other services on a focused map.

This is because we were adding the anomlies to the list of services from the initial query, but not to the list of services derived from the connections data.

Make the transformation that add anomalies happen after the derived services nodes are added.

This is done in the function that was called `dedupeConnections`, but since it does much more than dedupe connections has been renamed to `transformServiceMapResponses`.

Also make the node types extend `cytoscape.NodeDataDefinition` in order to simplify the types in the transformation (we were adding `& { id: string }` in some places which this replaces.)

Fixes elastic#65403.
@smith smith added the backport This PR is a backport of another PR label May 8, 2020
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 9a192da into elastic:7.8 May 8, 2020
@smith smith deleted the backport/7.8/pr-65882 branch May 8, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants