[SIEM] Eliminate Superfluous Untitled Timelines by patrykkopycinski · Pull Request #65783 · elastic/kibana

patrykkopycinski · 2020-05-07T21:59:30Z

Summary

This PR introduces a new type of timeline: draft, which will be used for temporary timeline investigations and is going to reduce amount of Untitled Timelines.

With these changes, if the user would like to keep the timeline investigation he has to put the title to the timeline, otherwise, he risks that the timeline data is going to be erased, as we are going to reuse the same draft timeline instance.

Changes in the PR:

Added REST urls for retrieving and resetting draft timeline:

GET /api/timeline/_draft to retrieve the draft timeline
POST /api/timeline/_draf/clean to reset the draft timeline

Updated import/export REST logic when importing/exporting draft timelines

when the draft timeline is exported the timelineType will be changed to default (as regular timelines)
when the draft timeline is imported the timelineType will be changed to default (as regular timelines)

Checklist

Unit or functional tests were updated or added to match the most common scenarios

patrykkopycinski · 2020-05-08T16:42:05Z

@elasticmachine merge upstream

patrykkopycinski · 2020-05-08T19:07:37Z

@elasticmachine merge upstream

XavierM

I tested locally and it does run smoothly!!!

BIG LGTM, thank you for refactoring and simplify your PR.

patrykkopycinski · 2020-05-11T18:53:19Z

@elasticmachine merge upstream

patrykkopycinski · 2020-05-12T07:09:57Z

@elasticmachine merge upstream

elasticmachine · 2020-05-12T07:09:59Z

merge conflict between base and head

…itled-timeline # Conflicts: # x-pack/plugins/siem/public/components/open_timeline/helpers.test.ts # x-pack/plugins/siem/public/components/open_timeline/index.test.tsx # x-pack/plugins/siem/public/components/open_timeline/open_timeline.tsx # x-pack/plugins/siem/public/components/open_timeline/types.ts # x-pack/plugins/siem/public/components/top_n/index.test.tsx # x-pack/plugins/siem/public/containers/timeline/api.ts # x-pack/plugins/siem/public/mock/timeline_results.ts # x-pack/plugins/siem/public/pages/timelines/index.tsx # x-pack/plugins/siem/public/store/timeline/defaults.ts # x-pack/plugins/siem/public/store/timeline/epic.ts # x-pack/plugins/siem/public/store/timeline/model.ts

patrykkopycinski · 2020-05-13T10:51:04Z

@elasticmachine merge upstream

patrykkopycinski · 2020-05-13T17:38:38Z

@elasticmachine merge upstream

kibanamachine · 2020-05-13T19:36:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4c7d785

History

💚 Build #47598 succeeded 7cdf5e4
💔 Build #47564 failed 075998d
💔 Build #47382 failed 601b920
💔 Build #47349 failed 91aa552
💚 Build #47058 succeeded 7c744fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

# Conflicts: # x-pack/plugins/siem/public/common/components/top_n/index.test.tsx # x-pack/plugins/siem/public/common/mock/timeline_results.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/helpers.test.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/index.test.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/open_timeline.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/types.ts # x-pack/plugins/siem/public/timelines/containers/api.ts # x-pack/plugins/siem/public/timelines/pages/index.tsx # x-pack/plugins/siem/public/timelines/store/timeline/defaults.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.ts # x-pack/plugins/siem/public/timelines/store/timeline/model.ts # yarn.lock

* [SIEM] Eliminate Superfluous Untitled Timelines (#65783) # Conflicts: # x-pack/plugins/siem/public/common/components/top_n/index.test.tsx # x-pack/plugins/siem/public/common/mock/timeline_results.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/helpers.test.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/index.test.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/open_timeline.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/types.ts # x-pack/plugins/siem/public/timelines/containers/api.ts # x-pack/plugins/siem/public/timelines/pages/index.tsx # x-pack/plugins/siem/public/timelines/store/timeline/defaults.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.ts # x-pack/plugins/siem/public/timelines/store/timeline/model.ts # yarn.lock * fix lock Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [SIEM] Eliminate Superfluous Untitled Timelines (#65783) # Conflicts: # x-pack/plugins/siem/public/common/components/top_n/index.test.tsx # x-pack/plugins/siem/public/common/mock/timeline_results.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/helpers.test.ts # x-pack/plugins/siem/public/timelines/components/open_timeline/index.test.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/open_timeline.tsx # x-pack/plugins/siem/public/timelines/components/open_timeline/types.ts # x-pack/plugins/siem/public/timelines/containers/api.ts # x-pack/plugins/siem/public/timelines/pages/index.tsx # x-pack/plugins/siem/public/timelines/store/timeline/defaults.ts # x-pack/plugins/siem/public/timelines/store/timeline/epic.ts # x-pack/plugins/siem/public/timelines/store/timeline/model.ts # yarn.lock * fix lint

angorayc and others added 30 commits April 8, 2020 12:48

init routes for template timeline

d3b3ba6

create template timeline

8a05dd9

Merge remote-tracking branch 'upstream/master' into template-timeline

79d53c8

add create/update timelines route

99f0da5

update api entry point

5a9b6ac

fix types

91798ee

add template type

dcae730

Merge remote-tracking branch 'upstream/master' into template-timeline

086996a

fix types

cab3e60

add types and template timeline id

a33cbb6

fix types

8243614

update import timeline to handle template timeline

89f2b12

unit test

464ee77

sudo code

3a37628

remove class for savedobject

9bb3552

add template timeline version

aba9d8e

clean up arguments

e26a803

fix types for framework request

5351219

show filter in find

7584715

fix create template timeline

d120d73

update mock data

7aeb123

handle missing timeline when exporting

7416fca

update the order for timeline routes

4b93431

update schemas

3c51485

Merge remote-tracking branch 'upstream/master' into template-timeline

c17ea0c

Merge remote-tracking branch 'upstream/master' into template-timeline

b94159f

move type to common folder so we can re-use them on UI and server side

0a7b275

fix types + integrate persist with epic timeline

0f22a03

update all timeline when persit timeline

bebb133

add timeline api readme

785ec34

Merge branch 'master' into feat/siem-untitled-timeline

4ba6d5c

Merge branch 'master' into feat/siem-untitled-timeline

64581f7

XavierM approved these changes May 11, 2020

View reviewed changes

Merge branch 'master' into feat/siem-untitled-timeline

7c744fa

patrykkopycinski added 3 commits May 12, 2020 17:27

fix merge

601b920

fix imports

075998d

Merge branch 'master' into feat/siem-untitled-timeline

7cdf5e4

patrykkopycinski marked this pull request as ready for review May 13, 2020 13:59

patrykkopycinski requested review from a team as code owners May 13, 2020 13:59

patrykkopycinski changed the title ~~Feat/siem untitled timeline~~ [SIEM] Eliminate Superfluous Untitled Timelines May 13, 2020

Merge branch 'master' into feat/siem-untitled-timeline

4c7d785

patrykkopycinski merged commit 65a0b44 into elastic:master May 13, 2020

patrykkopycinski deleted the feat/siem-untitled-timeline branch May 13, 2020 20:05

patrykkopycinski mentioned this pull request May 13, 2020

[7.x] [SIEM] Eliminate Superfluous Untitled Timelines (#65783) #66485

Merged

patrykkopycinski mentioned this pull request May 13, 2020

[7.8] [SIEM] Eliminate Superfluous Untitled Timelines (#65783) #66487

Merged

patrykkopycinski mentioned this pull request May 17, 2020

[SIEM] Refactor Timeline.timelineType draft to Timeline.status draft #66864

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Eliminate Superfluous Untitled Timelines#65783

[SIEM] Eliminate Superfluous Untitled Timelines#65783
patrykkopycinski merged 146 commits intoelastic:masterfrom
patrykkopycinski:feat/siem-untitled-timeline

patrykkopycinski commented May 7, 2020 •

edited

Loading

Uh oh!

patrykkopycinski commented May 8, 2020

Uh oh!

patrykkopycinski commented May 8, 2020

Uh oh!

XavierM left a comment •

edited

Loading

Uh oh!

patrykkopycinski commented May 11, 2020

Uh oh!

patrykkopycinski commented May 12, 2020

Uh oh!

elasticmachine commented May 12, 2020

Uh oh!

patrykkopycinski commented May 13, 2020

Uh oh!

patrykkopycinski commented May 13, 2020

Uh oh!

kibanamachine commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

patrykkopycinski commented May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

patrykkopycinski commented May 8, 2020

Uh oh!

patrykkopycinski commented May 8, 2020

Uh oh!

XavierM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski commented May 11, 2020

Uh oh!

patrykkopycinski commented May 12, 2020

Uh oh!

elasticmachine commented May 12, 2020

Uh oh!

patrykkopycinski commented May 13, 2020

Uh oh!

patrykkopycinski commented May 13, 2020

Uh oh!

kibanamachine commented May 13, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patrykkopycinski commented May 7, 2020 •

edited

Loading

XavierM left a comment •

edited

Loading